More warning conversions #16126
More warning conversions #16126
Conversation
rustbot
added
A-build-execution
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
rustc dev guide doesn't say anything about it. I'm not away of any extension of ours for how to deal with that. |
| The targets should have unique names. | ||
| Consider changing their names to be unique or compiling them separately. | ||
| This may become a hard error in the future; see <https://github.com/rust-lang/cargo/issues/6313>. | ||
| [WARNING] output filename collision at [ROOT]/foo/target/debug/deps/{}a{} |
| [HELP] Check that the patched package version and available features are compatible | ||
| with the dependency requirements. If the patch has a different version from | ||
| what is locked in the Cargo.lock file, run `cargo update` to use the new | ||
| version. This may also occur with an optional dependency that is not enabled. |
There was a problem hiding this comment.
@Muscraft thoughts on how this should be a formatted?
tests/testsuite/patch.rs
Outdated
| = [HELP] perhaps you misspelled the source URL being patched. Possible URLs for `[patch.<URL>]`: | ||
| = [HELP] [ROOT]/foo/bar |
There was a problem hiding this comment.
It feels weird for these list items to be in their own message
There was a problem hiding this comment.
If there aren't too many options, I think it looks fine inlined in the previous [HELP] message. Maybe it's worth filtering by edit distance, and then assuming there aren't too many options?
There was a problem hiding this comment.
Is there a style guide for list items in rustc?
There was a problem hiding this comment.
Not much but overall it seems each one is meant to be a distinct message. I would put the list all under one item.
Looking around rustc tests, I'm seeing
= note: the following trait bounds were not satisfied:
`Ipv4Addr: Iterator`
which is required by `Ipv4Addr: proc_macro::ext::RepIteratorExt`
`&Ipv4Addr: Iterator`
which is required by `&Ipv4Addr: proc_macro::ext::RepIteratorExt`
`Ipv4Addr: ToTokens`
which is required by `Ipv4Addr: proc_macro::ext::RepToTokensExt`
`&mut Ipv4Addr: Iterator`
which is required by `&mut Ipv4Addr: proc_macro::ext::RepIteratorExt`
help: consider importing one of these structs
╭╴
LL + use std::array::IntoIter;
├╴
LL + use std::collections::binary_heap::IntoIter;
├╴
LL + use std::collections::btree_map::IntoIter;
├╴
LL + use std::collections::btree_set::IntoIter;
│
╰ and 9 other candidates
jneem
force-pushed
the
warning-conversion
branch
2 times, most recently
from
47499a9 to
5227b39
Compare
jneem
force-pushed
the
warning-conversion
branch
from
5227b39 to
1cf1c9f
Compare
jneem
force-pushed
the
warning-conversion
branch
from
1cf1c9f to
0755364
Compare
4 participants
Yet another part of #15944.
I saw some inconsistent formatting for links: some are surrounded in "<>" but others aren't. Is there a policy for that?