Skip to content

Warning about unsupported LTO crete types #10537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

0xPoe
Copy link
Member

@0xPoe 0xPoe commented Apr 5, 2022

What does this PR try to resolve?

close #9672

Warning about unsupported LTO crete types.

How should we test and review this PR?

  • unit test

@rust-highfive
Copy link

r? @ehuss

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 5, 2022
@0xPoe 0xPoe force-pushed the rustin-patch-lto branch from 9f11766 to aa1b470 Compare April 5, 2022 13:12
@0xPoe 0xPoe force-pushed the rustin-patch-lto branch from aa1b470 to 620d667 Compare April 5, 2022 13:16
@0xPoe 0xPoe marked this pull request as draft April 5, 2022 13:23
@0xPoe
Copy link
Member Author

0xPoe commented Apr 5, 2022

Sorry, I didn't notice this recursive call. I will fix it later.

Signed-off-by: hi-rustin <[email protected]>
@0xPoe
Copy link
Member Author

0xPoe commented Apr 12, 2022

It looks like adding it has a big impact, or maybe I just didn't understand and implement it properly. So I close it.

@0xPoe 0xPoe closed this Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combination of lto=true and crate-type = ["cdylib", "rlib"] confusingly doesn't do lto
3 participants