Improve unused patch message when source URLs mismatched #10130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Resolve.unused_patches` does not contains info about which source URLs they are going to patch. As a result, we cannot provide a precise message but only list all possible URLs of the packages with the same name in the resolved graph. There is a little flaw that if multiple patches are patching the same package, the source URL of the used one would be shown as a possible URL in the warning.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ Seems reasonable to me, thanks! |
|
📌 Commit 91791c4 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 30, 2021
Update cargo 6 commits in 7f08ace4f1305de7f3b1b0e2f765911957226bd4..294967c53f0c70d598fc54ca189313c86c576ea7 2021-11-24 17:54:39 +0000 to 2021-11-29 19:04:22 +0000 - Fix some tests with output collisions. (rust-lang/cargo#10137) - Description of the targets that can be applied (rust-lang/cargo#10109) - Improve unused patch message when source URLs mismatched (rust-lang/cargo#10130) - Add a note about doctest xcompile. (rust-lang/cargo#10132) - book: add edit links to specific pages (rust-lang/cargo#10124) - Add crate type flag to rustc command (rust-lang/cargo#10093)
bors
added a commit
that referenced
this pull request
Aug 3, 2022
Grammar fixup unused patch message This is a minor grammar fixup to to message printed when patch source URLs mismatch (introduced in #10130).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8690
Resolve.unused_patchesdoes not contains info about which sourceURLs they are going to patch. As a result, we cannot provide a precise
message but only list all possible URLs of the packages with the same
name in the resolved graph.
There is a little flaw that if multiple patches are patching the same
package, the source URL of the used one would be shown as a possible
URL in the warning.