add timeout functionality for bisecting hangs #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12101111
reviewed
Oct 4, 2021
spastorino
reviewed
Oct 5, 2021
src/toolchains.rs
Outdated
| cmd | ||
| } | ||
| (None, Some(timeout)) => { | ||
| // let mut cmd = Command::new("cargo"); |
spastorino
approved these changes
Oct 5, 2021
|
Leaving this up to @ehuss |
|
Thanks! I removed the stray comment and resolved the FIXME and squashed the commits. This probably won't work on Windows, so if someone wants to follow up with a different solution, that is always an option. |
Closed
|
Superb, thanks everybody! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to #84. In addition to all the tests still running, I've manually tested it by using it trying to bisect rust-lang/rust#75860 and it seemed to work fine there. Seeing as it's a very small change I'm assuming that that is sufficient, but if more is needed, please let me know.
Couple of things to mention:
std::process::Commandand Windows also has a similar functinality I'm assuming that that will be sorted out automaticallyHope this helps, If there is anything that's missing, please let me know!