Skip to content

Add archive section to each page (fixes #485) #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

17cupsofcoffee
Copy link
Collaborator

Screenshot:

A few notes on the implementation:

  • I've not actually gone through and marked any crates as archived in this PR - I figured that could be done seperately (as a rework of Remove crates confirmed as dead #542?)
  • This should work for crates, games, and resources.
  • If a category has no archived crates, the section is hidden.
  • As discussed on the original issue, I wasn't sure what icon to use for the section - I didn't want to go for a thumbs down or a trashcan or anything like that, as that felt too negative. I ended up going for the 'bed' icon - the implication being the crates are asleep :p

@17cupsofcoffee
Copy link
Collaborator Author

@AngelOnFira - Would you be able to give this a quick review if you get some time? I'd like to get things moving with cleaning up AreWeGameYet, but with Ozkriff taking a step back there's not really anyone else to review my PRs 😅

(I do have admin rights so I could just unilaterally merge it, dunno how I feel about that though...)

@17cupsofcoffee
Copy link
Collaborator Author

I'm going to go ahead and merge this, as I feel like there's been a consensus that the site needs something like this for a long time now, (see #95) and it'd be a shame for it to continue to be blocked into 2024.

@17cupsofcoffee 17cupsofcoffee merged commit 3d2c169 into master Jan 1, 2024
@17cupsofcoffee 17cupsofcoffee deleted the archive-sections branch January 1, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant