Optionally trim whitespaces from env vars - #767
Draft
solontsev wants to merge 1 commit into
Draft
Conversation
solontsev
changed the title
Contributor
|
Note that our contrib guide asks for problems or requests to be discussed and acknowledged by a maintainer in an issue before posting a PR. I'll move this to a draft until that has happened. |
epage
marked this pull request as draft
August 10, 2026 17:44
Author
|
Thanks @epage ! Sorry I missed the requirement to open an issue. Just added it, happy to keep working on it and fix anything you'd like changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Environment::trim_values(bool), which trims leading and trailing whitespace from environment variable values. Off by default, so existing behaviour is unchanged.