Allow SecretKey to be deserialized from an owned string #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
force-pushed
the
deser-secret-key
branch
from
b407b77 to
5d27e37
Compare
Deserializing directly into a borrowed string only covers the edge case in which one passes a borrowed string to the deserializer. If we are given an owned version, the deserialization fails with: invalid type: string "foobar", expected a borrowed string'
thomaseizinger
force-pushed
the
deser-secret-key
branch
from
5d27e37 to
3b6dad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deserializing directly into a borrowed string only covers the edge
case in which one passes a borrowed string to the deserializer.
If we are given an owned version, the deserialization fails with: