Skip to content

Release 9.0.0 #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 14, 2022
Merged

Release 9.0.0 #488

merged 5 commits into from
Nov 14, 2022

Conversation

sanket1729
Copy link
Member

@sanket1729 sanket1729 commented Nov 5, 2022 •
edited
Loading

@sanket1729
Use expr_raw_pk_h for Terminal::RawPkH
43abc43 
Earlier, we only implemented `expr_raw_pkh` which was used as shortcut
for c:expr_raw_pk_h. Note the inclusion of additional _
@sanket1729
Bug fix: pkh->pk lookup API
815fd1c 
psbts where we needed to dissatisfy pkh did not work properly as we did
not implement the mapping pkh->pk required for dissatisfaction of pkh
fragment. We now look for this mapping in bip32 derivation field of
psbt.

Our update_utxo_from_descriptor API correctly procesess these fields.
@sanket1729
Don't run rawpkh logic through pkh
8f86992 
Fixes rust-bitcoin#483
@sanket1729
Add psbt example for sign and finalize
63ceb5b 
Same example as posted in discussions
@sanket1729 sanket1729 mentioned this pull request Nov 5, 2022
Merged
@apoelstra
Copy link
Member

I'm not sure that we can change the Display output in a patch release.

@apoelstra
Copy link
Member

Changing the signature of Satisfier::lookup_raw_pkh_pk we definitely can't do in a patch release.

@apoelstra
Copy link
Member

All changes in 7e1a7a0 look good to me, but they're all API-breaking and I think we need to release 9.0.0 with them.

@sanket1729
Copy link
Member Author

sanket1729 commented Nov 7, 2022 via email

@evd0kim
Copy link

evd0kim commented Nov 10, 2022

@apoelstra what is expected date for the next release if the fix goes with it?

@sanket1729
Copy link
Member Author

@engenegr, you can expect a new release early next week.

@sanket1729 sanket1729 changed the title Release 8.0.1 Release 9.0.0 Nov 12, 2022
@sanket1729
Copy link
Member Author

Changed to release 9.0.0

@apoelstra apoelstra mentioned this pull request Nov 14, 2022
Merged
@apoelstra
Copy link
Member

@sanket1729 you did not change the actual commit to 9.0.0!

@sanket1729
Copy link
Member Author

sanket1729 commented Nov 14, 2022 •
edited
Loading

@apoelstra , lol. Good catch. I think you mean Cargo.toml file?

apoelstra
apoelstra approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a113e35

@apoelstra apoelstra merged commit a7bfff4 into rust-bitcoin:master Nov 14, 2022
@apoelstra
Copy link
Member

Tagged & published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We should not be running pkh logic through rawpkh
3 participants
@sanket1729 @apoelstra @evd0kim