Add support for bitcoin core 29.0 #131

GideonBature · 2025-04-19T14:45:45Z

This PR adds support for the newly released bitcoin core version - v29.0

Updated RPCs

Implement getmininginfo which now returns nBits and the current target in the target field. It also returns a next object which specifies the height, nBits, difficulty, and target for the next block. (test added)
Implement getblock and getblockheader which now return the current target in the target field (test added)
Implement getblockchaininfo and getchainstates which now return nBits and the current target in the target field. (test added)
Implement getblocktemplate whose RPC curtime (BIP22) and mintime (BIP23) fields now account for the timewarp fix proposed in BIP94 on all networks. (test added)

New RPCs

Implement getdescriptoractivity rpc method which can be used to find all spend/receive activity relevant to a given set of descriptors within a set of specified blocks. (test added)

Closes #129

tcharding · 2025-04-21T22:09:27Z

CI fail can be fixed by creating the RPC help file, I haven't downloaded Core v29 yet but I'd expect that on this branch we could do:

contrib/run-bitcoind.sh start v29
bt29 help > verify/rpc-api-v29.txt

tcharding

Man this is looking pretty good! This crate is hard to work on so don't feel bad if you miss things. I'm having a hard time reviewing because the changeset is so big but I've left a few comments that will make it a fair bit smaller. Keep at it! Appreciate your effort.

types/src/v17/blockchain/mod.rs

types/src/v29/mod.rs

types/src/v29/blockchain/mod.rs

client/src/client_sync/v29/mod.rs

client/src/client_sync/v29/blockchain.rs

integration_test/tests/blockchain.rs

GideonBature · 2025-04-22T10:32:31Z

CI fail can be fixed by creating the RPC help file, I haven't downloaded Core v29 yet but I'd expect that on this branch we could do:
contrib/run-bitcoind.sh start v29
bt29 help > verify/rpc-api-v29.txt

I tried running the command after starting the bitcoind v29, but it keeps say the bt29 command not found, checked the repository to see if I can get anything that relates to that, but didn't find any...

tcharding · 2025-04-22T20:50:54Z

Oh I have a shell alias for each version, for v28 I have

bt28: aliased to bitcoin-cli -rpcconnect=localhost:28049 -rpcuser=*** -rpcpassword=***

And fill in the stars for your setup. Remember the leading 280 comes from the config file of .run-bitcoind.conf

GideonBature · 2025-04-23T00:30:17Z

Oh I have a shell alias for each version, for v28 I have
bt28: aliased to bitcoin-cli -rpcconnect=localhost:28049 -rpcuser=*** -rpcpassword=***
And fill in the stars for your setup. Remember the leading 280 comes from the config file of .run-bitcoind.conf

Thank you... It's done!

node/src/versions.rs

types/src/v29/mod.rs

tcharding · 2025-04-29T09:00:27Z

Can you get rid of all the formatting changes please.

GideonBature · 2025-04-29T16:47:46Z

Can you get rid of all the formatting changes please.

Done!

tcharding · 2025-04-29T21:28:19Z

It is surprising to see changes to types modules for any version other than v29. There are changes to v17. Please either remove them or justify why the changes are made.

GideonBature · 2025-04-30T16:33:23Z

It is surprising to see changes to types modules for any version other than v29. There are changes to v17. Please either remove them or justify why the changes are made.

Alright, so for v29, the getblocktemplate returns a Target field, in that case, I saw that v17 already has the getblocktemplate error, thus, I decided to add the target field Error variant to it so I could just reuse it for v29 instead of implementing the same thing for v29... I don't know if that counts... That was the reason why I added the additional field, but if it doesn't align with how the codebase is supposed to be, I can revert it back to it's original form and re-implement the error for v29 with target field....

tcharding · 2025-05-01T00:11:03Z

Yes please. Anything that is different in one version to another should have a separate type, errors included. I'm not totally convince that we should re-use errors at all but we already do in submitpackage IIRC and its kinda nice.

GideonBature · 2025-05-01T07:11:16Z

Yes please. Anything that is different in one version to another should have a separate type, errors included. I'm not totally convince that we should re-use errors at all but we already do in submitpackage IIRC and its kinda nice.

Alright, noted, I am going to do that right away...

tcharding · 2025-05-01T23:57:00Z

Can you add support to the run-bitcoind.sh script for running v29 as well mate?

tcharding · 2025-05-02T02:51:04Z

I just merged #142 so the docs format in v29/mod.rs will need updating in this PR.

GideonBature · 2025-05-02T20:05:42Z

Can you add support to the run-bitcoind.sh script for running v29 as well mate?

Definitely, although from how the script is, except I add it to the examples there, by default it should work with v29 if it is indicated in the config file.

GideonBature · 2025-05-02T20:08:03Z

I just merged #142 so the docs format in v29/mod.rs will need updating in this PR.

Noted!

tcharding · 2025-05-02T23:30:54Z

Can you add support to the run-bitcoind.sh script for running v29 as well mate?

Definitely, although from how the script is, except I add it to the examples there, by default it should work with v29 if it is indicated in the config file.

oooo, my bad I ran contrib/run-bitcoind.sh v29 (missing start) and from the error assumed we need to add something. Appologies.

tcharding · 2025-05-02T23:33:14Z

Needs a CI job man in the Integration job add a feature).

tcharding · 2025-05-02T23:42:54Z

If you run cd verify; cargo run -- v29 we get these warnings

Checking that the status claimed in the version specific rustdocs is correct ... 
missing model type: dumpwallet DumpWallet
missing return type: signrawtransactionwithwallet SignRawTransactionWithWallet
missing model type: signrawtransactionwithwallet SignRawTransactionWithWallet

Looks like the Method constructor on DumpWallet is wrong, I'll let you debug the other one.

GideonBature · 2025-05-02T23:52:03Z

Needs a CI job man in the Integration job add a feature).

If you run cd verify; cargo run -- v29 we get these warnings
Checking that the status claimed in the version specific rustdocs is correct ... 
missing model type: dumpwallet DumpWallet
missing return type: signrawtransactionwithwallet SignRawTransactionWithWallet
missing model type: signrawtransactionwithwallet SignRawTransactionWithWallet
Looks like the Method constructor on DumpWallet is wrong, I'll let you debug the other one.

Thank you for pointing this out, for the signrawtransactionwithwallet, I missed the type, instead of SignRawTransaction, I used SignRawTransactionWithWallet.

tcharding · 2025-05-02T23:56:12Z

verify is useful huh

GideonBature · 2025-05-02T23:58:57Z

Needs a CI job man in the Integration job add a feature).

Please I need more clarity on this... I added v29_0 in the rust.yaml in the .github directory, I don't know if it's same with what you are requesting for...

GideonBature · 2025-05-02T23:59:15Z

verify is useful huh

Very useful.

tcharding · 2025-05-05T05:15:10Z

On this branch are you able to run the v29 nodes with contrib/run-bitcoind.sh and then hit an RPC endpoint? I"m not able to run bitcoin-cli -rpcconnect=localhost:29049 -rpcuser=user -rpcpassword=password help . I can start the nodes but get

bt29 help
error: timeout on transient error: Could not connect to the server localhost:29049 (error code 2 - "error while reading header, or invalid header")

tcharding · 2025-05-05T05:17:38Z

Can you please update verify/src/method/v29.rs to match what was done in #140

tcharding · 2025-05-05T05:21:01Z

client/src/client_sync/mod.rs

+
+/// Arg for the `getblocktemplate` method. (v29+).
+#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq, Default)]
+pub struct TemplateRequestV29 {


This guy should be in v29/mod.rs (see how we handle AddressType in v17 and v23). You'll need to move the other one and remove the V29 from the type name.

Alright, noted...

I will open another PR that will address moving the one for v17.

client/src/client_sync/v29/blockchain.rs

types/src/v29/blockchain/mod.rs

tcharding · 2025-05-05T06:09:22Z

On further thought, so that I have a chance of reviewing this with more accuracy can you please split it up so that the first patch adds support for v29 putting 'TODO' for all the new methods. The add the methods as separate patches, either one per method if they are big or all together if it looks easy enough to review. Thanks man.

GideonBature · 2025-05-05T12:22:00Z

On this branch are you able to run the v29 nodes with contrib/run-bitcoind.sh and then hit an RPC endpoint? I"m not able to run bitcoin-cli -rpcconnect=localhost:29049 -rpcuser=user -rpcpassword=password help . I can start the nodes but get
bt29 help
error: timeout on transient error: Could not connect to the server localhost:29049 (error code 2 - "error while reading header, or invalid header")

woaw. I was able to run the command from my own end. That was what I used to generate the rpc-api txt file for v29. I was also able to run the script for v29 successfully... But I will check it again...

GideonBature · 2025-05-05T12:47:54Z

Can you please update verify/src/method/v29.rs to match what was done in #140

Done, I observed something, there were no division for util and signer.

GideonBature · 2025-05-05T13:51:54Z

On further thought, so that I have a chance of reviewing this with more accuracy can you please split it up so that the first patch adds support for v29 putting 'TODO' for all the new methods. The add the methods as separate patches, either one per method if they are big or all together if it looks easy enough to review. Thanks man.

Alright, there is only one new method for v29, which is the getdescriptoractivity, the other methods just had additional fields to the existing ones. Should I still go ahead with the split?

tcharding · 2025-05-05T21:26:18Z

oh bother, that's not worth the effort splitting man. Leave it as is, I'll work through it. My bad.

tcharding · 2025-05-05T21:58:58Z

What's the status of this bro? The client still has methods in that are not needed.

GideonBature · 2025-05-06T09:39:02Z

What's the status of this bro? The client still has methods in that are not needed.

Yes, I want to create another PR to move the other ones out of client to where they belong in v17/mod.rs reason been that those where not part of this PR, the one that is part of this PR has been moved, already... So I will open another PR to move the other one as well.

GideonBature force-pushed the support-29.0 branch 4 times, most recently from 5438355 to 1dbf4df Compare April 19, 2025 18:15

tcharding reviewed Apr 22, 2025

View reviewed changes

GideonBature force-pushed the support-29.0 branch 2 times, most recently from dc856f3 to 3c6c22f Compare April 22, 2025 20:08

GideonBature force-pushed the support-29.0 branch from 3c6c22f to 8135a58 Compare April 23, 2025 00:29

GideonBature force-pushed the support-29.0 branch 2 times, most recently from 798a62e to 2308f10 Compare April 23, 2025 05:19

tcharding reviewed Apr 28, 2025

View reviewed changes

node/src/versions.rs Outdated Show resolved Hide resolved

GideonBature force-pushed the support-29.0 branch 2 times, most recently from 20080f5 to 87a78dd Compare April 28, 2025 15:15

tcharding reviewed Apr 29, 2025

View reviewed changes

types/src/v29/mod.rs Show resolved Hide resolved

GideonBature force-pushed the support-29.0 branch 2 times, most recently from fb921bd to 5709498 Compare April 29, 2025 16:46

GideonBature force-pushed the support-29.0 branch 3 times, most recently from fa9350a to 1db66bf Compare April 29, 2025 17:13

GideonBature force-pushed the support-29.0 branch from 1db66bf to ab6e0aa Compare May 1, 2025 16:04

GideonBature force-pushed the support-29.0 branch 4 times, most recently from 3daa910 to f9e0d08 Compare May 1, 2025 21:45

GideonBature force-pushed the support-29.0 branch from f9e0d08 to 8a5e356 Compare May 2, 2025 21:30

GideonBature force-pushed the support-29.0 branch from 8a5e356 to 5bf883a Compare May 3, 2025 00:47

tcharding reviewed May 5, 2025

View reviewed changes

GideonBature force-pushed the support-29.0 branch from 5bf883a to c3f1b4f Compare May 5, 2025 19:21

Add support for bitcoin core 29.0

df6f1ee

GideonBature force-pushed the support-29.0 branch from c3f1b4f to df6f1ee Compare May 5, 2025 19:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for bitcoin core 29.0 #131

Add support for bitcoin core 29.0 #131

GideonBature commented Apr 19, 2025 •

edited

Loading

tcharding commented Apr 21, 2025

tcharding left a comment

GideonBature commented Apr 22, 2025

tcharding commented Apr 22, 2025

GideonBature commented Apr 23, 2025

tcharding commented Apr 29, 2025

GideonBature commented Apr 29, 2025

tcharding commented Apr 29, 2025

GideonBature commented Apr 30, 2025

tcharding commented May 1, 2025

GideonBature commented May 1, 2025

tcharding commented May 1, 2025

tcharding commented May 2, 2025

GideonBature commented May 2, 2025

GideonBature commented May 2, 2025

tcharding commented May 2, 2025

tcharding commented May 2, 2025 •

edited

Loading

tcharding commented May 2, 2025 •

edited

Loading

GideonBature commented May 2, 2025

tcharding commented May 2, 2025

GideonBature commented May 2, 2025

GideonBature commented May 2, 2025

tcharding commented May 5, 2025

tcharding commented May 5, 2025

tcharding May 5, 2025

GideonBature May 5, 2025

GideonBature May 5, 2025 •

edited

Loading

tcharding commented May 5, 2025

GideonBature commented May 5, 2025 •

edited

Loading

GideonBature commented May 5, 2025

GideonBature commented May 5, 2025

tcharding commented May 5, 2025 •

edited

Loading

tcharding commented May 5, 2025

GideonBature commented May 6, 2025

Add support for bitcoin core 29.0 #131

Are you sure you want to change the base?

Add support for bitcoin core 29.0 #131

Conversation

GideonBature commented Apr 19, 2025 • edited Loading

Updated RPCs

New RPCs

tcharding commented Apr 21, 2025

tcharding left a comment

Choose a reason for hiding this comment

GideonBature commented Apr 22, 2025

tcharding commented Apr 22, 2025

GideonBature commented Apr 23, 2025

tcharding commented Apr 29, 2025

GideonBature commented Apr 29, 2025

tcharding commented Apr 29, 2025

GideonBature commented Apr 30, 2025

tcharding commented May 1, 2025

GideonBature commented May 1, 2025

tcharding commented May 1, 2025

tcharding commented May 2, 2025

GideonBature commented May 2, 2025

GideonBature commented May 2, 2025

tcharding commented May 2, 2025

tcharding commented May 2, 2025 • edited Loading

tcharding commented May 2, 2025 • edited Loading

GideonBature commented May 2, 2025

tcharding commented May 2, 2025

GideonBature commented May 2, 2025

GideonBature commented May 2, 2025

tcharding commented May 5, 2025

tcharding commented May 5, 2025

tcharding May 5, 2025

Choose a reason for hiding this comment

GideonBature May 5, 2025

Choose a reason for hiding this comment

GideonBature May 5, 2025 • edited Loading

Choose a reason for hiding this comment

tcharding commented May 5, 2025

GideonBature commented May 5, 2025 • edited Loading

GideonBature commented May 5, 2025

GideonBature commented May 5, 2025

tcharding commented May 5, 2025 • edited Loading

tcharding commented May 5, 2025

GideonBature commented May 6, 2025

GideonBature commented Apr 19, 2025 •

edited

Loading

tcharding commented May 2, 2025 •

edited

Loading

tcharding commented May 2, 2025 •

edited

Loading

GideonBature May 5, 2025 •

edited

Loading

GideonBature commented May 5, 2025 •

edited

Loading

tcharding commented May 5, 2025 •

edited

Loading