Skip to content

MachineInfo in JSON #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

MachineInfo in JSON #80

merged 1 commit into from
May 9, 2025

Conversation

dkcumming
Copy link
Collaborator

Added MachineInfo to the JSON. This should give us the ability to use usize properly

jberthold
jberthold approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add it for now but we should maybe revise later. I would have thought this should be placed near the top (next to name and crate_id) but it might just be me.

@dkcumming dkcumming merged commit f452197 into master May 9, 2025
3 checks passed
@dkcumming dkcumming deleted the dc/machine-info branch May 9, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberthold jberthold jberthold approved these changes

@gtrepta gtrepta gtrepta approved these changes

@ehildenb ehildenb Awaiting requested review from ehildenb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkcumming @jberthold @gtrepta