Do not check mutability when computing projections #572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic for computing projections looks at the mutability of fields when reading them, which shouldn't be necessary as we should be allowed to read mutable fields (just not write them). So this removes the mutability check, which means the additional arguments
FORCE
andMUT
are not needed for#projectUpdate
. So we refactor the bits of state that aren't needed to be in a differentKItem
in the second position on the<k>
cell.In particular:
#projectUpdate
which inspect the mutability of the read fields and theFORCE
field.FORCE
) into a secondKItem
on the<k>
cell, and re-wires the rules to use this when doing#setLocalValue
.