Skip to content

Handwritten test expansion #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 16, 2023
Merged

Handwritten test expansion #257

merged 11 commits into from
Nov 16, 2023

Conversation

dkcumming
Copy link
Collaborator

This PR will properly organise the handwritten-rust/ directory to be easily navigable when trying to identify the coverage of semantic constructs. Different directories are used to distinguish between archetypes/features of the code. The tests in these directories aim to display reasonable coverage of the feature, that is to say, Rust that is typically used and not contrived edge cases. Edge cases and the boundaries of Rust are better handled by the Rust tests/ui/ test suite, which we use a subset of in this repository which is included in this project as a submodule.

Failing tests should be minimised to the smallest size that includes the failing feature.

@dkcumming dkcumming added the kmir-tests Adding/updating tests in KMIR label Nov 15, 2023
@dkcumming dkcumming self-assigned this Nov 15, 2023
@dkcumming dkcumming requested a review from yanliu18 November 16, 2023 03:48
@dkcumming dkcumming marked this pull request as ready for review November 16, 2023 03:49
@yanliu18
Copy link
Contributor

Hi @dkcumming, I feel these tests overlap with the compile-rs/ui test suits.
I am OK to approve it and use it for local testing of MIR semantics.
Though, we might try to reuse the test suits as much as possible.

@dkcumming
Copy link
Collaborator Author

All of them overlap with ui test suite, that's unavoidable. But often it is very hard to find a test that is short and testing just one particular thing in the ui test suite. Often many of them will rely on multiple things that we don't currently support. This list is meant to be a sort of unit test for particular features.

@dkcumming dkcumming merged commit eb62fa2 into master Nov 16, 2023
@dkcumming dkcumming deleted the conditional-examples branch November 16, 2023 04:07
@yanliu18 yanliu18 linked an issue Nov 28, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kmir-tests Adding/updating tests in KMIR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for kmir run with basic computations and control flow
2 participants