-
Notifications
You must be signed in to change notification settings - Fork 3
Handwritten test expansion #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @dkcumming, I feel these tests overlap with the compile-rs/ui test suits. |
All of them overlap with ui test suite, that's unavoidable. But often it is very hard to find a test that is short and testing just one particular thing in the ui test suite. Often many of them will rely on multiple things that we don't currently support. This list is meant to be a sort of unit test for particular features. |
This PR will properly organise the
handwritten-rust/
directory to be easily navigable when trying to identify the coverage of semantic constructs. Different directories are used to distinguish between archetypes/features of the code. The tests in these directories aim to display reasonable coverage of the feature, that is to say, Rust that is typically used and not contrived edge cases. Edge cases and the boundaries of Rust are better handled by the Rust tests/ui/ test suite, which we use a subset of in this repository which is included in this project as a submodule.Failing tests should be minimised to the smallest size that includes the failing feature.