Resolve Spotless + Java 17 #4869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add macOS Build & Test job to test-pr.yml with continue-on-error: true - Update release.yml to make macOS build and test jobs non-blocking - Keep macOS tests in place to monitor failures without blocking PRs/releases - Clean approach: test the failures without breaking the build pipeline This allows us to: - Monitor macOS build issues without blocking development - Collect data on macOS-specific failures - Fix issues incrementally without pressure - Maintain working CI/CD pipeline for other platforms
- Pull Changes from PR 4857 - Specify java 17 for macos teting
…' into fix/spotless-on-macos
- Goot Format Java is now on version 1.28.0
- Fixed the brew tap command format: Changed from brew tap runtimeverification/k . to brew tap runtimeverification/k "file://$(pwd)" to use the proper file:// URL format that Homebrew expects. - Added tap cleanup: Added brew untap runtimeverification/k 2>/dev/null || true before the tap command to remove any existing tap that might have a different remote configuration, preventing the "remote mismatch" error.
Problem: MacOS is deleting the release when it fails to build / test it's files and then release fails to proceed. - Removed section deleting release and let continue-on-error to do what it needs to do. Continue...
- Formula is defined in a different repo homebrew-k It does not make sense to control or report on this from a src where this code / file is not controlled. These tests need to move.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving TODO items from PR #4857