Skip to content

fix: Set Env variables when output: hide in multienv #5319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 24, 2025
Merged

fix: Set Env variables when output: hide in multienv #5319

merged 5 commits into from
May 24, 2025

Conversation

hkobayash
Copy link
Contributor

what

why

  • I want to suppress Dynamic environment variables added: message.

tests

go test -v ./server/core/runtime -run ^TestMultiEnvStepRunner_Run$
=== RUN   TestMultiEnvStepRunner_Run
=== RUN   TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_ONE=value1'
    logger.go:146: 2025-02-13T01:49:55.324+0900 DEBUG   starting 'sh -c "echo 'TF_VAR_REPODEFINEDVARIABLE_ONE=value1'"' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_ONE=value12886480706/001'
    logger.go:146: 2025-02-13T01:49:55.359+0900 INFO    successfully ran 'sh -c' 'echo 'TF_VAR_REPODEFINEDVARIABLE_ONE=value1'' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_ONE=value12886480706/001'      {"duration": "35.162916ms"}
=== RUN   TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_TWO=value=1='
    logger.go:146: 2025-02-13T01:49:55.364+0900 DEBUG   starting 'sh -c "echo 'TF_VAR_REPODEFINEDVARIABLE_TWO=value=1='"' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_TWO=value=1=2234019066/001'
    logger.go:146: 2025-02-13T01:49:55.371+0900 INFO    successfully ran 'sh -c' 'echo 'TF_VAR_REPODEFINEDVARIABLE_TWO=value=1='' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_TWO=value=1=2234019066/001'  {"duration": "7.586209ms"}
=== RUN   TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_NO_VALUE'
    logger.go:146: 2025-02-13T01:49:55.379+0900 DEBUG   starting 'sh -c "echo 'TF_VAR_REPODEFINEDVARIABLE_NO_VALUE'"' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_NO_VALUE254333198/001'
    logger.go:146: 2025-02-13T01:49:55.395+0900 INFO    successfully ran 'sh -c' 'echo 'TF_VAR_REPODEFINEDVARIABLE_NO_VALUE'' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_NO_VALUE254333198/001'   {"duration": "15.660917ms"}
=== RUN   TestMultiEnvStepRunner_Run/echo_'TF_VAR1_MULTILINE="foo\\nbar",TF_VAR2_VALUEWITHCOMMA="one,two",TF_VAR3_CONTROL=true'
    logger.go:146: 2025-02-13T01:49:55.398+0900 DEBUG   starting 'sh -c "echo 'TF_VAR1_MULTILINE=\"foo\\\\nbar\",TF_VAR2_VALUEWITHCOMMA=\"one,two\",TF_VAR3_CONTROL=true'"' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR1_MULTILINE=foonbar,TF_VAR2_VALUEWITHCOMMA=one,two,TF_VAR3_CONTROL=true3330121634/001'
    logger.go:146: 2025-02-13T01:49:55.404+0900 INFO    successfully ran 'sh -c' 'echo 'TF_VAR1_MULTILINE="foo\\nbar",TF_VAR2_VALUEWITHCOMMA="one,two",TF_VAR3_CONTROL=true'' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR1_MULTILINE=foonbar,TF_VAR2_VALUEWITHCOMMA=one,two,TF_VAR3_CONTROL=true3330121634/001'      {"duration": "6.035833ms"}
=== RUN   TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_HIDE=value1'
    logger.go:146: 2025-02-13T01:49:55.406+0900 DEBUG   starting 'sh -c "echo 'TF_VAR_REPODEFINEDVARIABLE_HIDE=value1'"' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_HIDE=value13894026439/001'
    logger.go:146: 2025-02-13T01:49:55.411+0900 INFO    successfully ran 'sh -c' 'echo 'TF_VAR_REPODEFINEDVARIABLE_HIDE=value1'' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_HIDE=value13894026439/001'    {"duration": "4.636083ms"}
--- PASS: TestMultiEnvStepRunner_Run (0.09s)
    --- PASS: TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_ONE=value1' (0.04s)
    --- PASS: TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_TWO=value=1=' (0.01s)
    --- PASS: TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_NO_VALUE' (0.02s)
    --- PASS: TestMultiEnvStepRunner_Run/echo_'TF_VAR1_MULTILINE="foo\\nbar",TF_VAR2_VALUEWITHCOMMA="one,two",TF_VAR3_CONTROL=true' (0.01s)
    --- PASS: TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_HIDE=value1' (0.01s)
PASS
ok      github.com/runatlantis/atlantis/server/core/runtime     0.372s

references

@hkobayash hkobayash requested review from a team as code owners February 12, 2025 16:56
@hkobayash hkobayash requested review from GenPage, lukemassa and X-Guardian and removed request for a team February 12, 2025 16:56
@dosubot dosubot bot added bug Something isn't working go Pull requests that update Go code labels Feb 12, 2025
@hkobayash
add test
16f2ce7 
Signed-off-by: Hirotake Kobayashi <[email protected]>
@hkobayash
fix: Set Env variables when output: hide in multienv
6901622 
Signed-off-by: Hirotake Kobayashi <[email protected]>
@hkobayash hkobayash force-pushed the fix/multienv_step_output branch from 2a8c860 to 6901622 Compare February 12, 2025 17:02
@arohter
Copy link

arohter commented Apr 4, 2025

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 23, 2025
@jamengual jamengual merged commit 5dfe5f9 into runatlantis:main May 24, 2025
41 checks passed
@jamengual
Copy link
Contributor

@hkobayash Thanks for the contribution

joe1981al pushed a commit to joe1981al/atlantis that referenced this pull request Jun 20, 2025
@hkobayash @jamengual @joe1981al
fix: Set Env variables when output: hide in multienv (runatlantis#5319
43c26bc 
)

Signed-off-by: Hirotake Kobayashi <[email protected]>
Co-authored-by: PePe Amengual <[email protected]>
Signed-off-by: Joseph McDonald <[email protected]>
@BrewTestBot BrewTestBot mentioned this pull request Jun 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@GenPage GenPage Awaiting requested review from GenPage GenPage was automatically assigned from runatlantis/maintainers

@lukemassa lukemassa Awaiting requested review from lukemassa lukemassa was automatically assigned from runatlantis/core-contributors

@X-Guardian X-Guardian Awaiting requested review from X-Guardian X-Guardian was automatically assigned from runatlantis/core-contributors

Assignees
No one assigned
Labels
bug Something isn't working go Pull requests that update Go code lgtm This PR has been approved by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Atlantis does not set Env variables when output: hide in multienv
3 participants
@hkobayash @arohter @jamengual