-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Aquery ivfflat fix #17922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Aquery ivfflat fix #17922
Conversation
As described in the issue, vector store index querying was not successful when the PGVectorStore was initialized with the `ivfflat_probes` argument. This problem is potentially due to the behavior of psycopg3 sending parameters separately, using [server-side binding](https://www.psycopg.org/psycopg3/docs/basic/from_pg2.html#server-side-binding), which may mis-behave when performed asynchronously. However, this is just a hypothesis and may be related to a different issue. The proposed solution works successfully and formats the variable directly in the `SET` string.
Adding pytest per conributing guidelines
…to aquery_ivfflat_fix
NOTE: This integration should be updated to use |
@logan-markewich Do you know of anyone that may be able to look into this? Our solution relies on many query engines/retrievers that all use the asynchronous querying ( We have tried:
Without being able to use asynchronous querying for this one step of our workflows, our workflows are severely slowed down. Any help would be greatly appreciated! |
Description
As described in the issue, vector store index querying was not successful
when the PGVectorStore was initialized with the
ivfflat_probes
argument.This problem is potentially due to the behavior of psycopg2/3 relying on server-side binding,
which does not support SET statements. However, this is just
a hypothesis and may be related to a different issue.
The proposed solution works successfully and formats the variable directly
in the
SET
string.Fixes # 17877
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lint
to appease the lint gods