-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat: Add OpenSearch Binary & Byte data_type support #17476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christopher-learningpool
wants to merge
10
commits into
run-llama:main
Choose a base branch
from
christopher-learningpool:opensearch-binary-byte-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7462cc0
feat: Add OpenSearch Binary & Byte data_type support
christopher-learningpool f61f8a6
version-dump
christopher-learningpool 258b409
Merge branch 'main' into opensearch-binary-byte-support
christopher-learningpool a60c31a
Merge branch 'main' into opensearch-binary-byte-support
christopher-learningpool 02c9329
Merge branch 'main' into opensearch-binary-byte-support
christopher-learningpool c025823
Merge branch 'main' into opensearch-binary-byte-support
logan-markewich e22c3ca
Merge branch 'main' into opensearch-binary-byte-support
logan-markewich d47f4e8
Merge branch 'main' into opensearch-binary-byte-support
logan-markewich e56a7ca
Merge branch 'main' into opensearch-binary-byte-support
christopher-learningpool 5804236
Merge branch 'main' into opensearch-binary-byte-support
logan-markewich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not 100% sure how I feel about changing this. But I guess it makes sense. This will likely cause some mypy errors? Lets see the linting output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a low-level change that I wasn't expecting to change. Any other changes to the core schema would be a more considerable breaking change if we wanted to add an embedding_type field and switch based on that.
Do you have any thoughts on how we should proceed? I suspect we'll see more need to add byte or binary support in the future.