Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/js parser interpreter #47

Merged
merged 22 commits into from
Dec 7, 2024
Merged

Feat/js parser interpreter #47

merged 22 commits into from
Dec 7, 2024

Conversation

ruifigueira
Copy link
Owner

Closes: #46

@ruifigueira ruifigueira force-pushed the feat/js-parser-interpreter branch 2 times, most recently from f34bf13 to 1b01427 Compare November 28, 2024 18:35
@ruifigueira
chore(api): crxApp.recorder.mode no longer a getter, it's a function …
25cee70 
…instead

Playwright doesn't use getters, so this makes it consistent
@ruifigueira ruifigueira force-pushed the feat/js-parser-interpreter branch from 1b01427 to 5163405 Compare November 29, 2024 23:10
@ruifigueira ruifigueira force-pushed the feat/js-parser-interpreter branch 2 times, most recently from e99707a to 39d99a4 Compare December 7, 2024 11:45
@ruifigueira
feat(parser): recorder script parser and interpreter
aba7461 
Allow to run and reset script
@ruifigueira
chore: crxRecorderApp now parses playwright-test
c035568 
Instead of parsing jsonl
@ruifigueira
patch(playwright): reverts jsonl structure changes
cd2b231 
Reverts 7c42163
@ruifigueira
patch(playwright): support loading script
6ef9c2f
@ruifigueira
patch(playwright): support code editing in recorder
fb6d28b
@ruifigueira
chore(parser): refactor parseForTest
6a4c776
@ruifigueira
patch(playwright): support openPage in playwright-test
17c11e1
@ruifigueira
chore(parser): support openPage action in parser
6f289ee
@ruifigueira
fix(player): browserContext.newPage api does not have params
75a6382
@ruifigueira
chore(parser): add implicit openPage action to parsed script
7d1677c 
Also, compute action line for non playwright-test sources
@ruifigueira
chore: open extensions page when browser launched
4b1b540
@ruifigueira
chore: ensure experimental features only triggered when enabled
bf9b085
@ruifigueira
chore: ensure recorder default is playwright-test
5f9d686
@ruifigueira
chore: use settings functions instead of chrome.storage
98fa70e
@ruifigueira
chore: save file now simply downloads it
9b9fa7f 
Saving with FileSystem API inside a sidepanel was not a good idea at all
@ruifigueira
chore(parser): handle recorder code editing
96f4373
@ruifigueira
test(parser): recorder editing tests
fec86e9
@ruifigueira
test: ensure recorder tests don't run on the sidepanel
603a89f
@ruifigueira
fix: page param in crxPlayer.run was being ignored
ca31b38
@ruifigueira
patch(playwright): make recorder._isRecording public
c78121b
@ruifigueira
chore(parser): improve code editing experience
ac43a0d 
- code keeps same formatting
- when changing to another language
  - if code is valid, changes replicate to the other languages
  - if it has an error, code is reset back to a valid state
@ruifigueira ruifigueira force-pushed the feat/js-parser-interpreter branch from 39d99a4 to ac43a0d Compare December 7, 2024 12:02
@ruifigueira ruifigueira marked this pull request as ready for review December 7, 2024 14:01
@ruifigueira ruifigueira merged commit a98de51 into main Dec 7, 2024
1 check passed
@ruifigueira ruifigueira deleted the feat/js-parser-interpreter branch December 9, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Basic javascript parser and interpreter
1 participant
@ruifigueira