web: Migrate to npm workspaces #6025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relrelb
force-pushed
the
npm_workspaces
branch
from
13c6b60 to
c0f5223
Compare
adrian17
approved these changes
Jan 10, 2022
|
Could this help with the CI failures: https://issueexplorer.com/issue/nextcloud/contacts/2352 ? |
|
Some other places recommend passing |
relrelb
force-pushed
the
npm_workspaces
branch
from
5a86a55 to
7018f9d
Compare
relrelb
changed the title
Herschel
reviewed
Jan 11, 2022
relrelb
force-pushed
the
npm_workspaces
branch
from
7018f9d to
3be019a
Compare
`lerna` is a bit stale, and as such it currently has some outdated dependencies which Dependabot warns on. Fortunately, npm 7 supports monorepos natively, via "workspaces". So simply replace `lerna` with this feature. The migration is pretty neat and requires a very little invervention. Because Node.js 14 comes with npm 6 by default, upgrade it manually as shown in bahmutov/npm-install#103 (comment).
relrelb
force-pushed
the
npm_workspaces
branch
from
3be019a to
86ccf30
Compare
torokati44
reviewed
Jan 11, 2022
| @@ -32,12 +37,11 @@ | |||
| "webpack-cli": "^4.9.1" | |||
| }, | |||
| "scripts": { | |||
| "bootstrap": "npm install && lerna bootstrap --hoist", | |||
| "build": "lerna run build --stream", | |||
| "build": "npm run build --workspaces", | |||
| "build:debug": "cross-env NODE_ENV=development CARGO_FEATURES=avm_debug npm run build", | |||
There was a problem hiding this comment.
Shouldn't the --workspaces argument also have been added on this line?
There was a problem hiding this comment.
It's not needed because it uses build that does npm run build --workspaces.
There was a problem hiding this comment.
I see, thanks. It's still not entirely clear to me "which" build script where runs when and why. I might read up on it. Until then, I'll remove it from #5834.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lernais a bit stale, and as such it currently has some outdateddependencies which Dependabot warns on.
Fortunately, npm 7 supports monorepos natively, via "workspaces". So
simply replace
lernawith this feature. The migration is prettyneat and requires a very little invervention.
Because Node.js 14 comes with npm 6 by default, upgrade it manually
as shown in bahmutov/npm-install#103 (comment).