avm2: fix localeCompare behaviour for swf versions <= 11 #21003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuchAFuriousDeath
changed the title
kjarosh
added
A-avm2
SuchAFuriousDeath
force-pushed
the
fix-string-locale-compare
branch
from
7b4e04e to
b4cc528
Compare
| let other = args.get_string(activation, 0)?; | ||
| let other_value = args.get_value(0); | ||
|
|
||
| if activation.caller_movie_or_root().version() <= 11 { |
There was a problem hiding this comment.
Are you sure activation.caller_movie_or_root().version() <= 11 is correct? In my version of FP, the special-case for null and undefined only activates in SWFv9 and SWFv10 (so activation.caller_movie_or_root().version() <= 10).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.