avm1: Remove Gc indirection for SuperObject
#20369
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moulins
added
A-avm1
kjarosh
reviewed
May 9, 2025
| depth: u8, | ||
|
|
||
| /// Adds a niche, so that enums contaning this type can use it for their discriminant. | ||
| _niche: crate::utils::ZeroU8, |
There was a problem hiding this comment.
How does this work exactly? Shouldn't Rust reuse this space for the discriminant anyway?
There was a problem hiding this comment.
Rust will never overlap a discriminant with padding, because padding can have any value (it's roughly like an invisible MaybeUninit<[u8; _]> field); adding the ZeroU8 field instead says that any SuperObject must have a zero byte at this offset.
moulins
force-pushed
the
avm1-no-super-indirection
branch
3 times, most recently
from
4043a71 to
dc58c1f
Compare
moulins
force-pushed
the
avm1-no-super-indirection
branch
from
dc58c1f to
6ccb56a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #20204.