core: Remove GcCell usage in MovieClipShared
#20310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moulins
force-pushed
the
cell-movie-clip-shared
branch
from
c6278e2 to
dd01076
Compare
moulins
added
A-core
moulins
force-pushed
the
cell-movie-clip-shared
branch
2 times, most recently
from
c3789d5 to
6ec740c
Compare
moulins
force-pushed
the
cell-movie-clip-shared
branch
2 times, most recently
from
237a074 to
201d0a0
Compare
moulins
force-pushed
the
cell-movie-clip-shared
branch
5 times, most recently
from
772b382 to
929d059
Compare
moulins
force-pushed
the
cell-movie-clip-shared
branch
2 times, most recently
from
0e1a193 to
1a01fa8
Compare
moulins
force-pushed
the
cell-movie-clip-shared
branch
from
1a01fa8 to
46e6262
Compare
moulins
force-pushed
the
cell-movie-clip-shared
branch
from
46e6262 to
8462b55
Compare
And refactor movieclip preloading logic by segregating mutable data into a separate GC-agnostic `MovieClipSharedMut` struct. This allows the removal of the convoluted static data cloning logic in `MovieClip::preload`.
Most of these do not need access to an actual MC instance; the only hold-out is AVM1's `do_init_action`.
moulins
force-pushed
the
cell-movie-clip-shared
branch
from
8462b55 to
3275ef3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, preloading now modifies the existing
MovieClipSharedinstance instead of swapping a clone on eachpreloadcall.This means that duplicating a partially-preloaded
MovieClipwill return a clip sharing the preload state. This seems "more correct" to me (as it means that both clips will properly finish preloading), but I haven't tested this in FP.EDIT: Added a further refactoring that moves most of the tag preloading methods to
MovieClipShared, as they mostly don't need access to the actual MC instance.