avm1: implement Sound getBytesTotal(), getBytesLoaded() #20235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
added
A-avm1
kjarosh
added
T-compat
|
Could someone test #12685? This is a very exciting development, thank you!! |
|
That game (fl0w) is able to stream its audio without starting it prematurely with this PR but it doesn't play it back. :/ |
adrian17
reviewed
Apr 24, 2025
There was a problem hiding this comment.
The code looks fine - that said, couldn't we mirror what AVM2 does here? As in, in avm2 sound.bytesLoaded/bytesTotal, we obtain the SoundHandle from the object and call audio.get_sound_size. Does this make any difference in behavior vs storing the state up front?
I'm unsure - I did it this way due to the way the function call returns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more correct functionality to getBytesLoaded() and getBytesTotal() - returning the actual number of bytes loaded from the network / from disk rather than always returning 1, as well as returning undefined on getBytesLoaded when loadSound has not been called and on getBytesTotal when the total length is unknown (request not completed).
This fixes https://old.homestarrunner.com/qod.swf - with extra debug logging added to aforementioned Flash file, the trace output between Ruffle and Flash matches with this PR applied.