avm2: hitTestPoint should only use local coordinates for the player root #20054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZingBallyhoo
force-pushed
the
hittestpoint-root
branch
2 times, most recently
from
d7d8bc1 to
e9b9a5a
Compare
kjarosh
added
A-avm2
ZingBallyhoo
force-pushed
the
hittestpoint-root
branch
from
e9b9a5a to
b351895
Compare
ZingBallyhoo
force-pushed
the
hittestpoint-root
branch
from
deb774a to
ad3866b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation in FP only appears to mirror the avm1 root-relative-coordinates thing when the root is from the player, not a loader.
Ref: #8933, #192