feat: add support for idenitify calls when anonymousid userId both present in ecom events #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allure Test reports for this run are available at: |
yashasvibajpai
changed the title
|
Allure Test reports for this run are available at: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat.id.stitching.across.checkouts.pixel.events #4092 +/- ##
===================================================================================
- Coverage 91.13% 91.10% -0.04%
===================================================================================
Files 629 629
Lines 32850 32868 +18
Branches 7792 7785 -7
===================================================================================
+ Hits 29938 29944 +6
- Misses 2664 2706 +42
+ Partials 248 218 -30 ☔ View full report in Codecov by Sentry. |
utsabc
reviewed
Feb 19, 2025
|
Allure Test reports for this run are available at: |
|
yashasvibajpai
merged commit b61d1c1
into
feat.id.stitching.across.checkouts.pixel.events
24 checks passed
yashasvibajpai
deleted the
feat.identify.calls.in.pixel.checkout.events
branch
yashasvibajpai
added a commit
that referenced
this pull request
Feb 20, 2025
* feat: add userId to web pixel events from redis if available * feat: stitching id in anonymous checkouts across checkouts (#4074) * chore: move anonymousId to userId redis setting to common util * chore: add userId enrichment for server side events * chore: address comments * chore: update ttl for cart token and userId mappings in redis * chore: address comments, add action support in identifier event * feat: add support for idenitify calls when anonymousid userId both present in ecom events (#4092) * feat: add support for idenitify calls when anonymousid userId both present * chore: update code, add test * chore: traits are inside context * chore: add stats for mapping get set operations * chore: fix codecov sonar issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
We will multiplex the ecom events where anonymousId and userId both are present, into an identify call also so as to allow downstream identification of these profiles properly.
What is the related Linear task?
Resolves INT-3250
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.