Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(destination): zoho search api params encoding #4077

Closed
wants to merge 2 commits into from

Conversation

maheshkutty
Copy link
Contributor

@maheshkutty maheshkutty commented Feb 13, 2025

What are the changes introduced in this PR?

  • Fixed an issue where an event with an action type of delete caused an error.
  • The transformation process involves calling the Zoho Search API to retrieve recordId using the criteria query parameter.
  • The criteria parameter follows this format:
    (({api_name}:{operator}:{value})and/or({api_name}:{operator}:{value}))
    
    where {value} needs to be properly escaped and encoded.
  • Our function for escaping and encoding values previously threw an error when the input was not a string.
  • This PR updates the function to first check if the value is a string. If it is, we escape and encode it; otherwise, we only encode it.

What is the related Linear task?

Resolves INT-3206

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@maheshkutty maheshkutty requested a review from a team as a code owner February 13, 2025 13:32
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.46%. Comparing base (c200518) to head (75ee930).
Report is 14 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (c200518) and HEAD (75ee930). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c200518) HEAD (75ee930)
2 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4077       +/-   ##
============================================
- Coverage    91.13%   62.46%   -28.67%     
============================================
  Files          629      225      -404     
  Lines        32837    12425    -20412     
  Branches      7791     3151     -4640     
============================================
- Hits         29925     7761    -22164     
- Misses        2696     3863     +1167     
- Partials       216      801      +585     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maheshkutty maheshkutty changed the base branch from develop to release/v1.91.0 February 18, 2025 06:04
krishna2020
krishna2020 previously approved these changes Feb 18, 2025
@maheshkutty maheshkutty force-pushed the fix.zoho_search_api_encoding branch from 71d5ff3 to 75ee930 Compare February 18, 2025 06:14
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Base automatically changed from release/v1.91.0 to main February 18, 2025 07:56
@sandeepdsvs sandeepdsvs dismissed krishna2020’s stale review February 18, 2025 07:56

The base branch was changed.

@maheshkutty maheshkutty changed the base branch from main to develop February 19, 2025 05:01
@maheshkutty maheshkutty requested review from sivashanmukh and a team as code owners February 19, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants