Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mixpanel ios property mapping ios_app_release and ios_app_version #4072

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

manish339k
Copy link
Contributor

What are the changes introduced in this PR?

swapping the mapping of $ios_app_release and $ios_app_version to fix the wrong mapping.

What is the related Linear task?

Resolves INT-3238

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@koladilip
Copy link
Contributor

how did arrive at this solution

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (aed87ce) to head (880ebef).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4072   +/-   ##
========================================
  Coverage    91.13%   91.13%           
========================================
  Files          629      629           
  Lines        32840    32840           
  Branches      7794     7791    -3     
========================================
  Hits         29928    29928           
+ Misses        2696     2664   -32     
- Partials       216      248   +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manish339k manish339k added the DO NOT MERGE Don't merge this PR without having discussion label Feb 13, 2025
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this PR without having discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants