-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: id stitching improvement in shopify pixel transformations #4060
feat: id stitching improvement in shopify pixel transformations #4060
Conversation
Allure Test reports for this run are available at: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4060 +/- ##
===========================================
+ Coverage 91.04% 91.14% +0.09%
===========================================
Files 629 629
Lines 32841 32875 +34
Branches 7792 7792
===========================================
+ Hits 29901 29964 +63
- Misses 2689 2695 +6
+ Partials 251 216 -35 ☔ View full report in Codecov by Sentry. |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
test/integrations/sources/shopify/webhookTestScenarios/GenericTrackTests.ts
Show resolved
Hide resolved
src/v1/sources/shopify/webhookTransformations/serverSideTransform.js
Outdated
Show resolved
Hide resolved
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
…esent in ecom events (#4092) * feat: add support for idenitify calls when anonymousid userId both present * chore: update code, add test * chore: traits are inside context
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
@yashasvibajpai fix these |
Fix sonar duplication issues |
68b7f52
Allure Test reports for this run are available at: |
|
What are the changes introduced in this PR?
We are handling
userId
enrichment from redis for anonymous as well as logged in users checkout scenarios.We will be getting the value of userId as customerId that was sent in the rudderIdentifier event and stored in redis as anonymousId <-> userId mapping
We will also multiplex the ecom events where anonymousId and userId both are present, into an identify call also so as to allow downstream identification of these profiles properly.
Other refactors include fixing some mappings that were being referenced from v0 source code have fixed those.
What is the related Linear task?
Resolves INT-3009
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.