Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: id stitching improvement in shopify pixel transformations #4060

Merged

Conversation

yashasvibajpai
Copy link
Member

@yashasvibajpai yashasvibajpai commented Feb 11, 2025

What are the changes introduced in this PR?

  • We are handling userId enrichment from redis for anonymous as well as logged in users checkout scenarios.
    We will be getting the value of userId as customerId that was sent in the rudderIdentifier event and stored in redis as anonymousId <-> userId mapping

  • We will also multiplex the ecom events where anonymousId and userId both are present, into an identify call also so as to allow downstream identification of these profiles properly.

Other refactors include fixing some mappings that were being referenced from v0 source code have fixed those.

What is the related Linear task?

Resolves INT-3009

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@yashasvibajpai yashasvibajpai self-assigned this Feb 11, 2025
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.14%. Comparing base (69a1d6b) to head (68b7f52).
Report is 39 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4060      +/-   ##
===========================================
+ Coverage    91.04%   91.14%   +0.09%     
===========================================
  Files          629      629              
  Lines        32841    32875      +34     
  Branches      7792     7792              
===========================================
+ Hits         29901    29964      +63     
- Misses        2689     2695       +6     
+ Partials       251      216      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@yashasvibajpai yashasvibajpai marked this pull request as ready for review February 17, 2025 07:53
@yashasvibajpai yashasvibajpai requested review from sivashanmukh and a team as code owners February 17, 2025 07:53
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

krishna2020
krishna2020 previously approved these changes Feb 18, 2025
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

…esent in ecom events (#4092)

* feat: add support for idenitify calls when anonymousid userId both present

* chore: update code, add test

* chore: traits are inside context
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

utsabc
utsabc previously approved these changes Feb 20, 2025
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@yashasvibajpai yashasvibajpai changed the title feat: add userId to web pixel events from redis if available feat: id stitching improvement in shopify pixel transformations Feb 20, 2025
krishna2020
krishna2020 previously approved these changes Feb 20, 2025
@koladilip
Copy link
Contributor

Codecov Report

Attention: Patch coverage is 94.44444% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.13%. Comparing base (69a1d6b) to head (e35a628).
Report is 38 commits behind head on develop.

Files with missing lines Patch % Lines
.../shopify/webpixelTransformations/pixelTransform.js 77.77% 2 Missing ⚠️
src/v1/sources/shopify/utils.js 90.90% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

@yashasvibajpai fix these

@koladilip
Copy link
Contributor

@yashasvibajpai yashasvibajpai dismissed stale reviews from krishna2020 and utsabc via 68b7f52 February 20, 2025 09:27
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@yashasvibajpai yashasvibajpai merged commit 558eab6 into develop Feb 20, 2025
27 checks passed
@yashasvibajpai yashasvibajpai deleted the feat.id.stitching.across.checkouts.pixel.events branch February 20, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants