-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: snapchat v3 #4052
base: develop
Are you sure you want to change the base?
feat: snapchat v3 #4052
Conversation
Allure Test reports for this run are available at: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4052 +/- ##
===========================================
- Coverage 90.82% 90.61% -0.22%
===========================================
Files 627 631 +4
Lines 32693 33098 +405
Branches 7765 7869 +104
===========================================
+ Hits 29695 29992 +297
- Misses 2775 2844 +69
- Partials 223 262 +39 ☔ View full report in Codecov by Sentry. |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
1 similar comment
Allure Test reports for this run are available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to typescript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandeepdsvs @ItsSudip was it raised as part of review ?
test/integrations/destinations/snapchat_conversion/processor/data.ts
Dismissed
Show dismissed
Hide dismissed
Allure Test reports for this run are available at: |
|
What are the changes introduced in this PR?
Added version 3 for snapchat
What is the related Linear task?
Resolves INT-2703
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.