Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: snapchat v3 #4052

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

feat: snapchat v3 #4052

wants to merge 4 commits into from

Conversation

aanshi07
Copy link
Contributor

@aanshi07 aanshi07 commented Feb 6, 2025

What are the changes introduced in this PR?

Added version 3 for snapchat

What is the related Linear task?

Resolves INT-2703

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@aanshi07 aanshi07 self-assigned this Feb 6, 2025
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 116 lines in your changes missing coverage. Please review.

Project coverage is 90.61%. Comparing base (ee33e5c) to head (ff47d41).
Report is 52 commits behind head on develop.

Files with missing lines Patch % Lines
...v0/destinations/snapchat_conversion/transformV3.js 54.34% 100 Missing and 5 partials ⚠️
src/v0/destinations/snapchat_conversion/utilsV3.js 47.36% 7 Missing and 3 partials ⚠️
...c/v0/destinations/snapchat_conversion/transform.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4052      +/-   ##
===========================================
- Coverage    90.82%   90.61%   -0.22%     
===========================================
  Files          627      631       +4     
  Lines        32693    33098     +405     
  Branches      7765     7869     +104     
===========================================
+ Hits         29695    29992     +297     
- Misses        2775     2844      +69     
- Partials       223      262      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

1 similar comment
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to typescript

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeepdsvs @ItsSudip was it raised as part of review ?

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
52.2% Coverage on New Code (required ≥ 80%)
25.3% Duplication on New Code (required ≤ 15%)
2 New Code Smells (required ≤ 1)
2 New Major Issues (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants