Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sources integration tests to parse v2 tests and some fixes for… #4051

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

vinayteki95
Copy link
Contributor

… old ones

What are the changes introduced in this PR?

  1. Source integration test generation script it updated
  • to fix v1 version integration test generation bugs
  • to implement v2 version integration test generation
  1. Type changes to simplify usage in rudder-server and rudder-ingestion service

What is the related Linear task?

Resolves INT-3149

Please explain the objectives of your changes below

Given that we are moving to the new webhook v2 contract, test cases will also be migrated and written in v2 format. To facilitate integation test generation to understand the new contract, changes are made.
Small bug fixes in generation are also addressed.

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

Yes, integration test generation produce cleaner test (especially removing query parameters from body)

Any new dependencies introduced with this change?

No

Any new generic utility introduced or modified. Please explain the changes.

Yes, source integration tests generation.

Any technical or performance related pointers to consider with the change?

No

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@vinayteki95 vinayteki95 requested review from sivashanmukh and a team as code owners February 6, 2025 07:24
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.00%. Comparing base (68497f9) to head (961592d).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4051   +/-   ##
========================================
  Coverage    91.00%   91.00%           
========================================
  Files          629      629           
  Lines        32824    32824           
  Branches      7788     7785    -3     
========================================
  Hits         29871    29871           
  Misses        2734     2734           
  Partials       219      219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

sonarqubecloud bot commented Feb 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants