Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip and fix tests that fail depending on user's local .gemrc file. #407

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martinemde
Copy link
Member

Description:

Without writing .gemrc, the gem source -a and -r don't work correctly. In particular, the presence of update_sources: true in .gemrc breaks one test, while writing the .gemrc fixes a previously skipped test.


Tasks:

  • Fixed local tests for different .gemrc configurations.
  • Un-skipped a test that works now with .gemrc written.

I will abide by the code of conduct.

@martinemde martinemde requested review from simi and segiddins March 28, 2025 17:12
@martinemde martinemde force-pushed the martinemde/fix-gemrc-in-private-spec branch from d119000 to f707f5a Compare March 28, 2025 19:34
@martinemde
Copy link
Member Author

Hey @segiddins, looks like you already took a stab at something like this in #401. This is passing and works for me locally on 3.1, 3.2, 3.3, and 3.4. The catch seems to be if you have update_sources: true in ~/.gemrc.

@martinemde martinemde force-pushed the martinemde/fix-gemrc-in-private-spec branch from f707f5a to 5441272 Compare March 28, 2025 19:38
Without writing .gemrc, the gem source -a and -r don't work correctly.
In particular, the presence of update_sources: true in .gemrc breaks one
test, while writing the .gemrc fixes a previously skipped test.
@martinemde martinemde force-pushed the martinemde/fix-gemrc-in-private-spec branch from 5441272 to 81121ee Compare March 28, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant