Fix transformation of some relative links #1431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
changed the title
olleolleolle
approved these changes
Jan 17, 2025
When the link started with the "h", "t", or "p" character, like in [Merging pull requests](playbooks/MERGING_A_PR.md), they would not be properly detected. This commit fixes it by properly using a negative lookahead.
deivid-rodriguez
force-pushed
the
fix-some-relative-links
branch
from
d869bab to
0a11f36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was some links in the doc folder imported from rubygems/rubygems were not being properly adapted to the site structure.
What was your diagnosis of the problem?
My diagnosis was that the regexp to detect relative links not starting with http was incorrect, because it would fail to detect any link with target starting with "h", "t", or "p" as relative.
What is your fix for the problem, implemented in this PR?
My fix is to properly use a negative lookahead.
This PR fixes #844. It depends on #1430 since that restore the whole page hierarchy under
/doc.