Update visual indicator for CSV downloads#5495
Open
awwaiid wants to merge 6 commits into
Open
Conversation
awwaiid
changed the title
dorner
requested changes
Feb 27, 2026
dorner
left a comment
dorner
left a comment
Collaborator
There was a problem hiding this comment.
couple comments - also, we should have a test for this, no? :) Or does the existing one cover it?
| def handle_csv_export | ||
| return unless params[:export_csv] | ||
|
|
||
| session[:trigger_csv_download] = true |
Collaborator
There was a problem hiding this comment.
Should we not just use flash for this?
| @@ -0,0 +1,5 @@ | |||
| <% if session.delete(:trigger_csv_download) %> | |||
| <% csv_url = "#{request.path}.csv#{"?#{request.query_string}" if request.query_string.present?}" %> | |||
| <iframe src="<%= csv_url %>" class="d-none"></iframe> | |||
Collaborator
There was a problem hiding this comment.
Let's add a comment here as to why we're doing this, because it's kind of weird 😛
Collaborator
Author
|
@dorner Yeah good call -- I added both a request spec for the flow and a system spec since this has a dash of js. |
Collaborator
|
This passes functional testing. |
Collaborator
Author
|
One more thing -- see if we can trigger the download with javascript instead of the iframe. |
Collaborator
Contributor
|
Automatically unassigned after 7 days of inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental change to download button (on distributions for now) to show a toast notification that the download is being processed/downloading. It disappears after 5 seconds.
There is a second PR upcoming that applies this to all CSV download buttons, but the scope for this PR is to look at the pattern first and apply it only to the Distributions csv export.