Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build #286

Merged
merged 2 commits into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [2.7, "3.0", 3.1, 3.2, 3.3]
ruby: ["2.7", "3.0", "3.1", "3.2", "3.3", "3.4"]
runs-on: ubuntu-latest
env:
FERRUM_PROCESS_TIMEOUT: 25
Expand All @@ -31,6 +31,11 @@ jobs:
with:
chrome-version: stable

- name: Fix GA Chrome Permissions
run: |
sudo chown root:root /opt/hostedtoolcache/setup-chrome/chromium/stable/x64/chrome-sandbox
sudo chmod 4755 /opt/hostedtoolcache/setup-chrome/chromium/stable/x64/chrome-sandbox

- name: Run tests
run: |
mkdir -p /tmp/cuprite
Expand Down
4 changes: 2 additions & 2 deletions cuprite.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ Gem::Specification.new do |s|

s.required_ruby_version = ">= 2.7.0"

s.add_runtime_dependency "capybara", "~> 3.0"
s.add_runtime_dependency "ferrum", "~> 0.16.0"
s.add_dependency "capybara", "~> 3.0"
s.add_dependency "ferrum", "~> 0.16.0"
end
3 changes: 2 additions & 1 deletion lib/capybara/cuprite/driver.rb
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,8 @@ def set_cookie(name, value, options = {})

def remove_cookie(name, **options)
options[:domain] = default_domain if options.empty?
browser.cookies.remove(**options.merge(name: name))
options = options.merge(name: name)
browser.cookies.remove(**options)
end

def clear_cookies
Expand Down
2 changes: 2 additions & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ module TestSessions
#has_css? with spatial requirements supports spatial sugar
#fill_in should fill in a textarea in a reasonable time by default
#has_element? should be true if the given element is on the page
#assert_matches_style should raise error if the elements style doesn't contain the given properties
#has_css? :style option should support Hash
REGEXP

intentional_skip = <<~REGEXP.split("\n").map { |s| Regexp.quote(s.strip) }.join("|")
Expand Down
Loading