Fix RuntimeError when using multiple hash splat operators#343
Closed
sinsoku wants to merge 1 commit intoruby:masterfrom
Closed
Fix RuntimeError when using multiple hash splat operators#343sinsoku wants to merge 1 commit intoruby:masterfrom
sinsoku wants to merge 1 commit intoruby:masterfrom
Conversation
When multiple hash splat operators expand hashes of the same type, duplicate edges were being added to the same vertex, causing `Set#<<` to raise an error. Modified `Vertex#add_edge` and `Vertex#remove_edge` to handle duplicate edges gracefully.
Member
|
Thank you! I would like to avoid modifying By the way, I am going to cut a release 0.31.0 next Tuesday. Let me know if you want to include any change for the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple hash splat operators expand hashes of the same type,
duplicate edges were being added to the same vertex, causing
Set#<<to raise an error. Modified
Vertex#add_edgeandVertex#remove_edgeto handle duplicate edges gracefully.