Fix NoMethodError in SigTyTupleNode#typecheck for instance types#339
Merged
mame merged 1 commit intoruby:masterfrom Oct 31, 2025
Merged
Conversation
`SigTyTupleNode#typecheck` was passing wrong parameter (ty instead of vtx)
to `f_ty.typecheck` when handling `Type::Instance` objects, causing:
"undefined method `each_type' for an instance of TypeProf::Core::Type::Instance".
```
/Users/sinsoku/ghq/github.com/ruby/typeprof/lib/typeprof/core/ast/sig_type.rb:5:in `typecheck_for_module': undefined method `each_type' for an instance of TypeProf::Core::Type::Instance (NoMethodError)
a_vtx.each_type do |ty|
^^^^^^^^^^
from /Users/sinsoku/ghq/github.com/ruby/typeprof/lib/typeprof/core/ast/sig_type.rb:669:in `typecheck'
from /Users/sinsoku/ghq/github.com/ruby/typeprof/lib/typeprof/core/ast/sig_type.rb:727:in `block (2 levels) in typecheck'
from /Users/sinsoku/ghq/github.com/ruby/typeprof/lib/typeprof/core/ast/sig_type.rb:726:in `each'
from /Users/sinsoku/ghq/github.com/ruby/typeprof/lib/typeprof/core/ast/sig_type.rb:726:in `block in typecheck'
```
9ba02ec to
6f3f738
Compare
Contributor
Author
|
I was able to create a scenario that reproduced the issue, so I force-pushed it. I found this issue while analyzing files in Redmine v6.10. The steps to reproduce are as follows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SigTyTupleNode#typecheckwas passing wrong parameter (ty instead of vtx)to
f_ty.typecheckwhen handlingType::Instanceobjects, causing:"undefined method `each_type' for an instance of TypeProf::Core::Type::Instance".