Remove eval workaround for keyword arguments in SigAttrReaderNode and SigAttrWriterNode#329
Merged
mame merged 1 commit intoruby:masterfrom Jun 24, 2025
Conversation
TypeProf now supports keyword arguments, so the eval workaround is no longer necessary. This makes the code more readable and maintainable by directly calling RBS::MethodType.new with keyword arguments. Changes: - Remove eval blocks from SigAttrReaderNode#initialize - Remove eval blocks from SigAttrWriterNode#initialize - Remove associated TODO comments 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
evalworkaround that was used to prevent TypeProf from failing to parse keyword arguments during dogfooding. Since TypeProf now supports keyword arguments, this workaround is no longer necessary.