Support RBS::AST::Members::InstanceVariable#322
Merged
mame merged 2 commits intoruby:masterfrom Jun 20, 2025
Merged
Conversation
sinsoku
reviewed
May 4, 2025
Co-Authored-By: Takumi Shotoku <sinsoku.listy@gmail.com>
Member
|
@S-H-GAMELINKS Thank you very much for the contribution and very sorry for my very late response! I will merge it soon |
Contributor
Author
|
@mame |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was implementing TypeProf LSP plugin for coc.nvim, and I found the following this error.
'TypeProf::Core::AST.create_rbs_member': unsupported: RBS::AST::Members::InstanceVariable (RuntimeError)Reading the code based on the error message, I found that an error occurs when instance variable written in RBS.
Therefore, I have added the
SigInstanceVariableNodeclass that can be used in the case ofRBS::AST::Members::InstanceVariableinTypeProf::Core::AST.create_rbs_membermethod.However, I am not familiar with the internal code of TypeProf, so I would appreciate any comments if you have any better ways of writing it.