Update Prism to 1.4.0 and remove workarounds#312
Merged
mame merged 2 commits intoruby:masterfrom Apr 28, 2025
Merged
Conversation
mame
approved these changes
Apr 28, 2025
Member
mame
left a comment
mame
left a comment
There was a problem hiding this comment.
Since Ruby 3.4 bundles prism 1.2.0 by default, I was wondering that I should get stuck with prism 1.2.0... But If I asked myself "should I add a CI matrix for prism 1.2.0?", I don't want so. So I will merge it!
gemmaro
added a commit
to gemmaro/typeprof
that referenced
this pull request
Nov 3, 2025
* typeprof.gemspec:, Gemfile, Gemfile.lock: Using TypeProf as a
library does not resolve Gemfile dependencies, so move Prism to
gemspec file. Notice that TypeProf now uses Prism version 1.4.0 or
later[1].
[1] Update Prism to 1.4.0 and remove workarounds,
ruby#312
mame
pushed a commit
that referenced
this pull request
Nov 4, 2025
* typeprof.gemspec:, Gemfile, Gemfile.lock: Using TypeProf as a
library does not resolve Gemfile dependencies, so move Prism to
gemspec file. Notice that TypeProf now uses Prism version 1.4.0 or
later[1].
[1] Update Prism to 1.4.0 and remove workarounds,
#312
mame
pushed a commit
that referenced
this pull request
Nov 4, 2025
* typeprof.gemspec:, Gemfile, Gemfile.lock: Using TypeProf as a
library does not resolve Gemfile dependencies, so move Prism to
gemspec file. Notice that TypeProf now uses Prism version 1.4.0 or
later[1].
[1] Update Prism to 1.4.0 and remove workarounds,
#312
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Prism dependency from 1.0.0 to 1.4.0 and removes workarounds that were needed for the old version.