Support for rb_io_mode_t.
#129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
ext/stringio/stringio.c:39
- Verify that the fallback definition of rb_io_mode_t as an int is consistent with its definition in 'ruby/io.h' to avoid potential type mismatches.
typedef int rb_io_mode_t;
ext/stringio/stringio.c:47
- Ensure that all usages of the 'flags' field align with rb_io_mode_t semantics, especially regarding potential signedness differences.
rb_io_mode_t flags;
ioquatix
force-pushed
the
support-rb_io_mode_t
branch
from
bac8694 to
f753b90
Compare
1 task
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Apr 15, 2025
(ruby/stringio#129) Companion PR to <#7894>. ruby/stringio@2d3988e12f
|
There is another fix for frozen string literals that we should merge before a release, but yes that would be great. |
|
Yes more discussion is required but it’s definitely a big. I trust Jeremy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to ruby/ruby#7894.