Do not pollute source directory by tests #8989
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simi
reviewed
Sep 23, 2025
|
|
||
| def tmp_root | ||
| source_root.join("tmp") | ||
| ruby_core? && (tmpdir = ENV["TMPDIR"]) ? Pathname(tmpdir) : source_root.join("tmp") |
Contributor
There was a problem hiding this comment.
Why is ruby_core? needed? Not possible to just respect ENV["TMPDIR"] if present?
hsbt
added a commit
that referenced
this pull request
Jan 26, 2026
Revert "Merge pull request #8989 from nobu/test-tmpdir"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Tests should not pollute the source directory by temporary files.
What is your fix for the problem, implemented in this PR?
Respect the
TMPDIRenvironment variable set by the ruby core test runner.Make sure the following tasks are checked