-
Notifications
You must be signed in to change notification settings - Fork 252
Handle nil value in GetbyteForSSLSocket::getbyte #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not sure that this will completely fix #266. This might just result in a different error. But it seems to me that this should be the correct behavior, and it looks like at least some of the places that call this do expect to get nil back sometimes. |
thanks for the PR! Currently I am not able to push a new release, because I am on vacation an fortunately far away from my computer. I am back at the beginning of August. |
Any chances for merging this pull request in? |
Any progress on this? |
This PR fixed an issue for us when interfacing with the Duo Authentication LDAP proxy. It seems to be low risk and would be helpful if merged. |
I also ran into this bug when using haproxy as LDAPS proxy in front of a pool of AD LDAP servers and haproxy dropped the connection because none of the backendas where healthy. |
@HarlemSquirrel Would it be possible to get a review of this fix please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to #266