Skip to content

Handle nil value in GetbyteForSSLSocket::getbyte #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

tmccombs
Copy link
Contributor

Related to #266

@tmccombs
Copy link
Contributor Author

I'm not sure that this will completely fix #266. This might just result in a different error. But it seems to me that this should be the correct behavior, and it looks like at least some of the places that call this do expect to get nil back sometimes.

@schaary
Copy link
Member

schaary commented Jul 13, 2018

thanks for the PR! Currently I am not able to push a new release, because I am on vacation an fortunately far away from my computer. I am back at the beginning of August.

@dawid-sklodowski
Copy link

Any chances for merging this pull request in?

@dklotz
Copy link

dklotz commented Sep 25, 2018

@schaary @mtodd Any chance a maintainer could look at this and #308 ?

@tmccombs
Copy link
Contributor Author

Any progress on this?

@cjs
Copy link

cjs commented Mar 25, 2019

This PR fixed an issue for us when interfacing with the Duo Authentication LDAP proxy. It seems to be low risk and would be helpful if merged.

@felixbuenemann
Copy link

I also ran into this bug when using haproxy as LDAPS proxy in front of a pool of AD LDAP servers and haproxy dropped the connection because none of the backendas where healthy.

@Greg-Myers-SB
Copy link

@HarlemSquirrel Would it be possible to get a review of this fix please?
I believe a few forks exist solely to use this patch.

Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarlemSquirrel HarlemSquirrel merged commit 626c312 into ruby-ldap:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants