refactor connection establishment #180
Conversation
|
|
||
| private | ||
|
|
||
| def use_connection(auth) |
There was a problem hiding this comment.
Needs documentation.
What are your thoughts on accepting the full args here instead of just the auth hash? While we're only using the auth portion, it seems overly specific for the scope of the method (connection management) and could evolve to need all of the connection options.
There was a problem hiding this comment.
documented, and switched to passing the full args hash
ccutrer
force-pushed
the
use_connection
branch
from
2b259db to
8cbbfc0
Compare
| if @open_connection | ||
| yield @open_connection | ||
| else | ||
| @result = 0 |
There was a problem hiding this comment.
We need to pull @result out of this method. It would be fine to have a local result that gets passed back to the caller.
0 is a strange default, too.
reduces duplicated code, and makes it easier for future changes to connection establishment because it's all in one place now
ccutrer
force-pushed
the
use_connection
branch
from
8cbbfc0 to
443fdb1
Compare
|
new version without assigning to @Result directly in use_connection is pushed |
|
@ccutrer rebasing/force-pushing changes isn't necessary, though it's fine if that's your preference. RE: using |
| # Yields an open connection if there is one, otherwise establishes a new | ||
| # connection, binds, and yields it. If binding fails, it will return the | ||
| # result from that, and :use_connection: will not yield at all. If not | ||
| # the return value is whatever is returned from the block. |
There was a problem hiding this comment.
Was thinking it'd be good to document that the result of the block is passed through, since that's relevant to the @result = assignment we do in the caller. Not a blocker but would be good to communicate that.
There was a problem hiding this comment.
Derp, didn't read well enough, that's exactly what's documented here.
| end | ||
| ensure | ||
| conn.close if conn | ||
| end |
There was a problem hiding this comment.
This method feels very similar to Net::LDAP#open.
|
Think this is good to go. My comments aren't blockers, and this sets us up to iterate more ably than we were before so I think holding off would be pointless. |
refactor connection establishment
refactor connection establishment
reduces duplicated code, and makes it easier for future changes
to connection establishment because it's all in one place now