Just keep helpers method in the public scope.
#2586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Write a test for it? Even something trivial like ensuring a specific method is not part of the public scope, so we don't accidentally introduce a regression. |
ericproulx
force-pushed
the
fix_helpers_methods_in_public_scope
branch
2 times, most recently
from
16fd227 to
30e188f
Compare
ericproulx
force-pushed
the
fix_helpers_methods_in_public_scope
branch
from
30e188f to
8ef110c
Compare
dblock
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the visibility of the helper methods in
Grape::DSL::Helpersfromprotectedtoprivate. This ensures that these internal methods are not accessible as part of the public or protected API, improving encapsulation and reducing the risk of accidental usage outside their intended scope.Change Summary
protectedtoprivatefor internal methods inlib/grape/dsl/helpers.rb.Rationale
Marking these methods as
privateclarifies their intended usage and helps prevent misuse by consumers of the DSL.