fix(hook): reduce hook spawn overhead#970
Open
zerone0x wants to merge 2 commits intortk-ai:developfrom
Open
Conversation
Contributor
|
Hello, Thanks for the contribution Please sign the CLA above so we can merge this |
Fixes rtk-ai#968 Co-Authored-By: Claude <noreply@anthropic.com>
f7f5b93 to
74a1fd2
Compare
pszymkowiak
approved these changes
Apr 3, 2026
Collaborator
pszymkowiak
left a comment
There was a problem hiding this comment.
Thanks @zerone0x — solid optimization. The version cache, herestring instead of echo|jq, and single-pass jq are all good improvements for reducing hook overhead (#968).
Two notes (non-blocking):
- The cache file (
~/.cache/rtk-hook-version-ok) has no expiry — after anrtkupgrade, the old cache persists. Consider adding the version to the filename (e.g.,rtk-hook-version-ok-0.34) or clearing it onrtk init. - This PR modifies
rtk-rewrite.shwhich is also modified by PR #981 (permission model). Whichever merges first will cause a conflict on the other — just a heads-up for rebase.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #968
Test plan
cargo fmt --all && cargo clippy --all-targets && cargo testrtk <command>output inspected