fix(gh): print 'No Pull Requests' when pr list is empty#779
fix(gh): print 'No Pull Requests' when pr list is empty#779saschabuehrle wants to merge 1 commit intortk-ai:developfrom
Conversation
|
|
📊 Automated PR Analysis
SummaryThis PR fixes issue #764 where Review Checklist
Linked issues: #764 Analyzed automatically by wshm · This is an automated analysis, not a human review. |
pszymkowiak
left a comment
There was a problem hiding this comment.
Thanks @saschabuehrle — the fix in gh_cmd.rs is exactly right, clean early return on empty PR list.
However, this PR includes 2500+ lines from develop that are already merged (copilot, cursor, windsurf, cline, openclaw, codex hooks, etc.). Only the 12 lines in gh_cmd.rs are new.
Could you rebase your branch on the latest develop so only your fix shows in the diff? That way we can review and merge cleanly.
git fetch upstream develop
git rebase upstream/develop
git push --force-with-lease|
Hey We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes No logic changes — only file moves and import path updates. What you need to doRebase your branch on git fetch origin && git rebase origin/developGit detects renames automatically. If you get import conflicts, update the paths: use crate::git; // now: use crate::cmds::git::git;
use crate::tracking; // now: use crate::core::tracking;
use crate::config; // now: use crate::core::config;
use crate::init; // now: use crate::hooks::init;
use crate::gain; // now: use crate::analytics::gain;Need help rebasing? Tag @aeppling |
|
Hi maintainers — I’m trying to complete the CLA for this PR, but the CLA assistant link/check is not loading on my side. Could you please re-trigger or refresh the CLA check for this PR? I’ll sign immediately once it’s accessible. Thanks! |
a4268ff to
6a51de3
Compare
|
Rebased this branch onto current develop and force-pushed. Diff is now only the empty PR list guard in gh_cmd.rs.\n\nGreetings, saschabuehrle |
|
Branch is rebased on develop and the diff is now just the empty-list guard in gh_cmd.rs. Please re-review when you have time.\n\nGreetings, saschabuehrle |
Bug
#764 —
rtk gh pr listprints an empty header with no feedback when there are zero pull requests.Fix
Added early return with a user-friendly message (
No Pull RequestsorNo PRsin ultra-compact mode) when the parsed JSON array is empty, matching the existing pattern forrtk gh issue list.Testing
Verified by running
rtk gh pr liston a repo with no open PRs. Confirmed the message renders correctly in both normal and ultra-compact (-U) modes.Happy to address any feedback.
Greetings, saschabuehrle