Add rtk python3 command with module routing and traceback filtering#429
Open
seungwoo-ji-03 wants to merge 5 commits intortk-ai:developfrom
Open
Add rtk python3 command with module routing and traceback filtering#429seungwoo-ji-03 wants to merge 5 commits intortk-ai:developfrom
seungwoo-ji-03 wants to merge 5 commits intortk-ai:developfrom
Conversation
95d999d to
9702036
Compare
dc20fc4 to
cc93afc
Compare
Author
|
@pszymkowiak Could you take a look when you get a chance? This addresses #285 by adding python3/python command routing and traceback filtering. Happy to walk through any part of the implementation. |
Contributor
|
Hey We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes No logic changes — only file moves and import path updates. What you need to doRebase your branch on git fetch origin && git rebase origin/developGit detects renames automatically. If you get import conflicts, update the paths: use crate::git; // now: use crate::cmds::git::git;
use crate::tracking; // now: use crate::core::tracking;
use crate::config; // now: use crate::core::config;
use crate::init; // now: use crate::hooks::init;
use crate::gain; // now: use crate::analytics::gain;Need help rebasing? Tag @aeppling |
…aceback filter Signed-off-by: seungwoo-ji (jeus) <jiseungwoo0210@gmail.com>
…g modules Signed-off-by: seungwoo-ji (jeus) <jiseungwoo0210@gmail.com>
Signed-off-by: seungwoo-ji (jeus) <jiseungwoo0210@gmail.com>
…3_cmd Signed-off-by: seungwoo-ji (jeus) <jiseungwoo0210@gmail.com>
9702036 to
5ab0c78
Compare
Author
|
@aeppling Rebased on develop. All tests passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python3was detected 75 times as unsupported inrtk discover --allrtk python3/rtk pythoncommands that:-m <module>to existing filters (pytest, mypy, ruff, pip)-m py_compilewith compactok ✓outputpython3 -m pytest/pip/ruffcorrectly classified to specific rtk commandsBefore / After
rtk python3 -m pytest tests/rtk pytestrtk python3 -m pip listrtk piprtk python3 script.py(crash)python3 -m ruff check .(discover)rtk ruff(80%)Test plan
cargo fmt+cargo clippycleanFixes #285