Make RTIC 2 not require nightly by using main's stack as an allocator
#888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korken89
added
skip-changelog
korken89
force-pushed
the
feature/stable-support
branch
from
519d337 to
22ecaf6
Compare
korken89
force-pushed
the
feature/stable-support
branch
2 times, most recently
from
34c8efe to
808dc14
Compare
korken89
force-pushed
the
feature/stable-support
branch
from
0d2d5ce to
d78da46
Compare
korken89
force-pushed
the
feature/stable-support
branch
2 times, most recently
from
457ec3e to
dcea309
Compare
korken89
force-pushed
the
feature/stable-support
branch
from
bbac2ee to
de41e9a
Compare
korken89
force-pushed
the
feature/stable-support
branch
from
de41e9a to
4152983
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR RTIC v2 will work on stable from 1.75 and forward.
This is done by instead of using Type Alias Impl Trait to do static allocations of async executors (causing us to require nightly), we are now using the stack of
main(before userinitis called) to allocate the async executors there. Basically doing a manualalloca.From testing this seems to not have any performance impact compared to TAIT other than startup taking a few extra cycles to move the pointer to the global storage.