-
Notifications
You must be signed in to change notification settings - Fork 225
fix edition 2024 unsafe link section #1055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix edition 2024 unsafe link section #1055
Conversation
Really nice you spotted it and got it sorted! Thank you 🚀 Would be amazing if this could be caught in the future with some UI test or similar, something you could look into perhaps? |
Oh, I am really now sure how to use existing framework to do this kind of test. When developing this, I used |
Oh, I probably found a way. Rust gives warning if rtic is not using it |
d311dc8
to
1e809d9
Compare
Is this possible to make a ui test in |
5c59e72
to
0db5840
Compare
0db5840
to
8390759
Compare
I honestly didn't find a better way to tests this. Rust would issue additional warning if attribute would get ignored, and that will cause the test to fail. |
@AfoHT I think this is some flaky test, that test failes and fixes randomly |
In edition 2024, we must use
#[unsafe(link_section = ...)]
instead of#[link_section = ...]
. Butrtic_macros
is only checking for#[link_section = ...]
.link_section
is used asunsafe(link_section = ...)