Fix #780: rtic-sync panic #1030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An explicit PR that fixes the bug but sidesteps the addition of
loom
to avoid the side effects it may introduce.Fixes #780
Extracts the relevant bugfix part from #1027
A description of the path leading to the bug, which also proves that the fix actually solves the problem:
try_recv
pushes intofreeq
.wait_queue
, an interrupt occurs.send
no. 1 eats up thefreeq
slot.send
no. 2 is called, pushes its link towait_queue
and goes to sleep (becausefreeq
is now empty)try_recv
, which popswait_queue
(from the newly waitingsend
call) without touching the free queue.send
is awoken at some point. Its link is popped, but thefreeq
is empty.