Skip to content

D2h visual #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,974 changes: 1,974 additions & 0 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
"mini-css-extract-plugin": "2.7.7",
"mkdirp": "3.0.1",
"nopt": "7.2.0",
"postcss": "8.4.33",
"postcss": "^8.4.33",
"postcss-cli": "11.0.0",
"postcss-import": "16.0.0",
"postcss-loader": "7.3.4",
Expand Down
1 change: 1 addition & 0 deletions src/diff2html.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export const defaultDiff2HtmlConfig = {
...defaultSideBySideRendererConfig,
outputFormat: OutputFormatType.LINE_BY_LINE,
drawFileList: true,
lineFolding: false
};

export function parse(diffInput: string, configuration: Diff2HtmlConfig = {}): DiffFile[] {
Expand Down
43 changes: 27 additions & 16 deletions src/line-by-line-renderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,15 @@ export interface LineByLineRendererConfig extends renderUtils.RenderConfig {
renderNothingWhenEmpty?: boolean;
matchingMaxComparisons?: number;
maxLineSizeInBlockForComparison?: number;
lineFolding?: boolean;
}

export const defaultLineByLineRendererConfig = {
...renderUtils.defaultRenderConfig,
renderNothingWhenEmpty: false,
matchingMaxComparisons: 2500,
maxLineSizeInBlockForComparison: 200,
lineFolding: true
};

const genericTemplatesPath = 'generic';
Expand Down Expand Up @@ -70,6 +72,7 @@ export default class LineByLineRenderer {
file: file,
fileHtmlId: renderUtils.getHtmlId(file),
diffs: diffs,
diffClass: (this.config.lineFolding) ? 'd2h-wrapped-file-diff' : '',
filePath: filePathTemplate.render(
{
fileDiffName: renderUtils.filenameDiff(file),
Expand All @@ -96,11 +99,13 @@ export default class LineByLineRenderer {

return file.blocks
.map(block => {
let lines = this.hoganUtils.render(genericTemplatesPath, 'block-header', {
CSSLineClass: renderUtils.CSSLineClass,
blockHeader: file.isTooBig ? block.header : renderUtils.escapeForHtml(block.header),
lineClass: 'd2h-code-linenumber',
contentClass: 'd2h-code-line',
let lines = this.hoganUtils.render(genericTemplatesPath, 'line', {
lineContent: this.hoganUtils.render(genericTemplatesPath, 'block-header', {
CSSLineClass: renderUtils.CSSLineClass,
blockHeader: file.isTooBig ? block.header : renderUtils.escapeForHtml(block.header),
lineClass: 'd2h-code-linenumber',
contentClass: 'd2h-code-line',
})
});

this.applyLineGroupping(block).forEach(([contextLines, oldLines, newLines]) => {
Expand All @@ -113,13 +118,15 @@ export default class LineByLineRenderer {
} else if (contextLines.length) {
contextLines.forEach(line => {
const { prefix, content } = renderUtils.deconstructLine(line.content, file.isCombined);
lines += this.generateSingleLineHtml(file, {
type: renderUtils.CSSLineClass.CONTEXT,
prefix: prefix,
content: content,
oldNumber: line.oldNumber,
newNumber: line.newNumber,
});
lines += this.hoganUtils.render(genericTemplatesPath, 'line', {
lineContent: this.generateSingleLineHtml(file, {
type: renderUtils.CSSLineClass.CONTEXT,
prefix: prefix,
content: content,
oldNumber: line.oldNumber,
newNumber: line.newNumber,
})
})
});
} else if (oldLines.length || newLines.length) {
const { left, right } = this.processChangedLines(file, file.isCombined, oldLines, newLines);
Expand Down Expand Up @@ -253,8 +260,12 @@ export default class LineByLineRenderer {

generateLineHtml(file: DiffFile, oldLine?: DiffPreparedLine, newLine?: DiffPreparedLine): FileHtml {
return {
left: this.generateSingleLineHtml(file, oldLine),
right: this.generateSingleLineHtml(file, newLine),
left: this.hoganUtils.render(genericTemplatesPath, 'line', {
lineContent: this.generateSingleLineHtml(file, oldLine)
}),
right: this.hoganUtils.render(genericTemplatesPath, 'line', {
lineContent: this.generateSingleLineHtml(file, newLine),
})
};
}

Expand All @@ -265,8 +276,8 @@ export default class LineByLineRenderer {
oldNumber: line.oldNumber || '',
newNumber: line.newNumber || '',
});

return this.hoganUtils.render(genericTemplatesPath, 'line', {
return this.hoganUtils.render(genericTemplatesPath, 'line-content', {
type: line.type,
lineClass: 'd2h-code-linenumber',
contentClass: 'd2h-code-line',
Expand Down
1 change: 1 addition & 0 deletions src/render-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export interface RenderConfig {
maxLineLengthHighlight?: number;
diffStyle?: DiffStyleType;
colorScheme?: ColorSchemeType;
lineFolding?: boolean;
}

export const defaultRenderConfig = {
Expand Down
47 changes: 40 additions & 7 deletions src/side-by-side-renderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,15 @@ export interface SideBySideRendererConfig extends renderUtils.RenderConfig {
renderNothingWhenEmpty?: boolean;
matchingMaxComparisons?: number;
maxLineSizeInBlockForComparison?: number;
lineFolding?: boolean;
}

export const defaultSideBySideRendererConfig = {
...renderUtils.defaultRenderConfig,
renderNothingWhenEmpty: false,
matchingMaxComparisons: 2500,
maxLineSizeInBlockForComparison: 200,
lineFolding: true
};

const genericTemplatesPath = 'generic';
Expand Down Expand Up @@ -65,11 +67,12 @@ export default class SideBySideRenderer {
const filePathTemplate = this.hoganUtils.template(genericTemplatesPath, 'file-path');
const fileIconTemplate = this.hoganUtils.template(iconsBaseTemplatesPath, 'file');
const fileTagTemplate = this.hoganUtils.template(tagsBaseTemplatesPath, renderUtils.getFileIcon(file));

debugger;
return fileDiffTemplate.render({
file: file,
fileHtmlId: renderUtils.getHtmlId(file),
diffs: diffs,
diffClass: (this.config.lineFolding) ? 'd2h-wrapped-file-diff' : '',
filePath: filePathTemplate.render(
{
fileDiffName: renderUtils.filenameDiff(file),
Expand Down Expand Up @@ -207,12 +210,28 @@ export default class SideBySideRenderer {
}

makeHeaderHtml(blockHeader: string, file?: DiffFile): string {
return this.hoganUtils.render(genericTemplatesPath, 'block-header', {
const lineFolding = this.config.lineFolding;
let headerContent = this.hoganUtils.render(genericTemplatesPath, 'block-header', {
CSSLineClass: renderUtils.CSSLineClass,
blockHeader: file?.isTooBig ? blockHeader : renderUtils.escapeForHtml(blockHeader),
lineClass: 'd2h-code-side-linenumber',
contentClass: 'd2h-code-side-line',
});
if(blockHeader.length !== 0) {
if(lineFolding) {
headerContent += this.hoganUtils.render(genericTemplatesPath, 'block-header', {
CSSLineClass: renderUtils.CSSLineClass,
blockHeader: "",
lineClass: 'd2h-code-side-linenumber',
contentClass: 'd2h-code-side-line',
});
}
return this.hoganUtils.render(genericTemplatesPath, 'line', {
lineContent: headerContent
});
} else {
return blockHeader;
}
}

processChangedLines(isCombined: boolean, oldLines: DiffLine[], newLines: DiffLine[]): FileHtml {
Expand Down Expand Up @@ -274,17 +293,31 @@ export default class SideBySideRenderer {
}

generateLineHtml(oldLine?: DiffPreparedLine, newLine?: DiffPreparedLine): FileHtml {
return {
left: this.generateSingleHtml(oldLine),
right: this.generateSingleHtml(newLine),
};
const lineFolding = this.config.lineFolding;
if(lineFolding) {
return {
left: this.hoganUtils.render(genericTemplatesPath, 'line', {
lineContent: this.generateSingleHtml(oldLine) + this.generateSingleHtml(newLine)
}),
right: ''
};
} else {
return {
left: this.hoganUtils.render(genericTemplatesPath, 'line', {
lineContent: this.generateSingleHtml(oldLine)
}),
right: this.hoganUtils.render(genericTemplatesPath, 'line', {
lineContent: this.generateSingleHtml(newLine),
})
};
}
}

generateSingleHtml(line?: DiffPreparedLine): string {
const lineClass = 'd2h-code-side-linenumber';
const contentClass = 'd2h-code-side-line';

return this.hoganUtils.render(genericTemplatesPath, 'line', {
return this.hoganUtils.render(genericTemplatesPath, 'line-content', {
type: line?.type || `${renderUtils.CSSLineClass.CONTEXT} d2h-emptyplaceholder`,
lineClass: line !== undefined ? lineClass : `${lineClass} d2h-code-side-emptyplaceholder`,
contentClass: line !== undefined ? contentClass : `${contentClass} d2h-code-side-emptyplaceholder`,
Expand Down
11 changes: 5 additions & 6 deletions src/templates/generic-block-header.mustache
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<tr>
<td class="{{lineClass}} {{CSSLineClass.INFO}}"></td>
<td class="{{CSSLineClass.INFO}}">
<div class="{{contentClass}}">{{#blockHeader}}{{{blockHeader}}}{{/blockHeader}}{{^blockHeader}}&nbsp;{{/blockHeader}}</div>
</td>
</tr>
<td class="{{lineClass}} {{CSSLineClass.INFO}}"></td>
<td class="{{CSSLineClass.INFO}}">
<div class="{{contentClass}}">{{#blockHeader}}{{{blockHeader}}}{{/blockHeader}}{{^blockHeader}}&nbsp;{{/blockHeader}}</div>
</td>

19 changes: 19 additions & 0 deletions src/templates/generic-line-content.mustache
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<td class="{{lineClass}} {{type}}">
{{{lineNumber}}}
</td>
<td class="{{type}}">
<div class="{{contentClass}}">
{{#prefix}}
<span class="d2h-code-line-prefix">{{{prefix}}}</span>
{{/prefix}}
{{^prefix}}
<span class="d2h-code-line-prefix">&nbsp;</span>
{{/prefix}}
{{#content}}
<span class="d2h-code-line-ctn">{{{content}}}</span>
{{/content}}
{{^content}}
<span class="d2h-code-line-ctn"><br></span>
{{/content}}
</div>
</td>
22 changes: 3 additions & 19 deletions src/templates/generic-line.mustache
Original file line number Diff line number Diff line change
@@ -1,21 +1,5 @@
{{#lineContent}}
<tr>
<td class="{{lineClass}} {{type}}">
{{{lineNumber}}}
</td>
<td class="{{type}}">
<div class="{{contentClass}}">
{{#prefix}}
<span class="d2h-code-line-prefix">{{{prefix}}}</span>
{{/prefix}}
{{^prefix}}
<span class="d2h-code-line-prefix">&nbsp;</span>
{{/prefix}}
{{#content}}
<span class="d2h-code-line-ctn">{{{content}}}</span>
{{/content}}
{{^content}}
<span class="d2h-code-line-ctn"><br></span>
{{/content}}
</div>
</td>
{{{lineContent}}}
</tr>
{{/lineContent}}
2 changes: 1 addition & 1 deletion src/templates/line-by-line-file-diff.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div class="d2h-file-header">
{{{filePath}}}
</div>
<div class="d2h-file-diff">
<div class="d2h-file-diff {{diffClass}}">
<div class="d2h-code-wrapper">
<table class="d2h-diff-table">
<tbody class="d2h-diff-tbody">
Expand Down
4 changes: 3 additions & 1 deletion src/templates/side-by-side-file-diff.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div class="d2h-file-header">
{{{filePath}}}
</div>
<div class="d2h-files-diff">
<div class="d2h-files-diff {{diffClass}}">
<div class="d2h-file-side-diff">
<div class="d2h-code-wrapper">
<table class="d2h-diff-table">
Expand All @@ -12,6 +12,7 @@
</table>
</div>
</div>
{{#diffs.right}}
<div class="d2h-file-side-diff">
<div class="d2h-code-wrapper">
<table class="d2h-diff-table">
Expand All @@ -21,5 +22,6 @@
</table>
</div>
</div>
{{/diffs.right}}
</div>
</div>
35 changes: 33 additions & 2 deletions src/ui/css/diff2html.css
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@
display: inline-block;
overflow-x: scroll;
overflow-y: hidden;
width: 50%;
/* width: 50%; */
flex-basis: 100%;
}

.d2h-code-line {
Expand All @@ -216,14 +217,15 @@
}

.d2h-code-line-ctn {
display: inline-block;
display: inline;
background: none;
padding: 0;
word-wrap: normal;
white-space: pre;
user-select: text;
width: 100%;
vertical-align: middle;

}

.d2h-code-line del,
Expand Down Expand Up @@ -283,6 +285,7 @@
border: solid var(--d2h-line-border-color);
border-width: 0 1px 0 1px;
cursor: pointer;
height: 100%;
}

.d2h-code-linenumber:after {
Expand Down Expand Up @@ -599,6 +602,34 @@
border: var(--d2h-dark-moved-label-color) 1px solid;
}

/* line folding */

.d2h-wrapped-file-diff .d2h-code-line-ctn {
white-space: break-spaces;
word-break: break-word;
}

.d2h-wrapped-file-diff .d2h-code-side-line {
width: auto;
}

.d2h-wrapped-file-diff .d2h-info .d2h-code-side-line {
white-space: break-spaces;
}

.d2h-wrapped-file-diff tr {
position: relative;
}

.d2h-wrapped-file-diff tr .d2h-code-side-linenumber {
height: 100%;
}

.d2h-wrapped-file-diff .d2h-file-side-diff tr .d2h-cntx:nth-child(2), .d2h-wrapped-file-diff .d2h-file-side-diff tr .d2h-cntx:nth-child(4) {
width: 50%;
}


/**
* Auto Mode Colors
*/
Expand Down
6 changes: 6 additions & 0 deletions website/templates/pages/demo/content.handlebars
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@
</select>
</label>
</div>
<div class="column is-one-sixth-widescreen">
<label title="Show the file list summary before the diff">
<p>Line Folding</p>
<input class="options-label-value" id="diff-url-options-line-folding" type="checkbox" name="drawFileList"/>
</label>
</div>
<div class="column is-one-sixth-widescreen">
<label title="Show the file list summary before the diff">
<p>File Summary</p>
Expand Down
Loading